In Site Registration - #76

@sandal when you have a moment can you review and update the text on the registration pages. Once that is all set we can merge this into master and deploy it.

@jordanbyron: Copy is updated, I think this is ready to go.

@sandal I've made those few changes we discussed to the problems page. Just take a look at the text on that page and make sure it looks good to you. Thanks! 😄

@jordanbyron: I think the tests should verify the whole resubscirbe process rather than just verifying that they can reach the subscribe page. In theory, that should take mostly the same path through the code, but I think a complete test would help us catch current or future edge cases.

Other than that, looks good.

@sandal I fixed up those tests as requested. If everything looks good I'll try deploying again tomorrow.

Make it so.

@jordanbyron: One question, what happens when a previous subscriber attempts to visit the subscribe page while not logged in? Does it authenticate them and display the problems page, and then they need to click the resubscribe link? If so, that's acceptable, but it may be better to handle that automatically so that they can seamlessly resubscribe without having to explicitly hit the /restart route.

This is not a blocker for deploying this code unless it somehow leads to an inconsistent state to visit /subscribe as a former subscriber that is not logged in, but is something we should look into.

What happens when a previous subscriber attempts to visit the subscribe page while not logged in? Does it authenticate them and display the problems page, and then they need to click the resubscribe link?

Yes that is the flow. Initially I thought about just re-routing them to the registration process, but that could be super confusing if they never knew their account was disabled by MailChimp.

I also considered changing the MailChimp webhooks to mark those accounts as status = 'payment_pending', however I thought that would just make things even more confusing when we asked them to start paying down the road. Most user's accounts are canceled without their knowledge and I think it's best if we show them the problems page and have them go through the full registration process.

Let me know what you think. I plan on deploying this branch within the next hour or so.

@jordanbyron I guess this boils down to the problem of figuring out their status when they come back from Github. Let's leave it as-is for now, and see how it goes.

@sandal deployed 🤘