Skip to content

Suggested changes to Contributing.md - #15

Merged
embray merged 2 commits into
embray:patch-3from
kelle:patch-3-kc
May 31, 2021
Merged

embray merged 2 commits into
embray:patch-3from
kelle:patch-3-kc

Conversation

@kelle

@kelle kelle commented Apr 29, 2021

Copy link
Copy Markdown

I moved the Anti-Imposter Syndrome text to the beginning, moved the Tips to the end. Polished some text.

Could you take another look at the text in the Checklist section? I would like to encourage folks to submit PRs even if they don't check all the boxes. I also think it's worth telling people to state explicitly in the PR if they want someone else to take it over or if they want help doing it themselves. I don't know how to phrase that.

Also, I know there are some extra files in this PR....I'm not sure how to get rid of them. Feel free to close this PR and just make the suggested changes yourself. :)

@embray

embray commented May 31, 2021

Copy link
Copy Markdown
Owner

Not sure how I missed this one!

@embray

embray commented May 31, 2021

Copy link
Copy Markdown
Owner

I fixed up the commit history; IIUC the only commit that was supposed to be included was 1b61542 ? Thanks!

@embray
embray merged commit bd76e7d into embray:patch-3 May 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants