Repository navigation
process_model.php: Various cleanup - #1979
Merged
Merged
Conversation
reedy
commented
Jan 24, 2026
reedy
commented
Contributor
- Add some braces round conditionals
- Swap some for loops for foreach
- Leave some TODOs
- Move some setup/processing later if it may not be used due to errors
* Add some braces round conditionals * Swap some for loops for foreach * Leave some TODOs * Move some setup/processing later if it may not be used due to errors
Contributor
|
Carefull with changing for to foreach, ensure referemces and variables names mantain the same behaviour as before. |
Member
|
Thanks @reedy ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.