Repository navigation
Add a simple one-entry-per-line file format for specifying symbol lists - #14170
Merged
Merged
Conversation
sbc100
force-pushed
the
simple_response_file
branch
7 times, most recently
from
May 12, 2021 22:37
b40c741 to
8b4ad19
Compare
kripken
reviewed
May 13, 2021
sbc100
force-pushed
the
simple_response_file
branch
from
May 13, 2021 20:27
8b4ad19 to
2d2eec2
Compare
sbc100
enabled auto-merge (squash)
May 13, 2021 20:28
For options such as `EXPORTED_FUNCTIONS` that take lists we now support a simple file format that is just one line per symbol. It doesn't require any escaping or punctuation. This is much easier to use maintain and is in line with other compiler toolchain options used by gcc and ld. For example ld's `--retain-symbols-file=filename` or wasm-ld's `--undefined-file=filename`. This should be especially useful for options like `ASYNCIFY_ADD` or `ASYNCIFY_REMOVE` which often involvea lot of quoting (because they include things like spaces and commas).
sbc100
force-pushed
the
simple_response_file
branch
from
May 13, 2021 20:34
2d2eec2 to
1e56a39
Compare
kripken
approved these changes
May 17, 2021
Collaborator
Author
|
Did you add commits there? (just a rebase?) |
Member
|
(yes, I happened to see you had automerge, and that it no longer merged cleanly due to a 1-line issue. so I fixed it for automerge's benefit, as otherwise I think you might not get a ping from github?) |
Collaborator
Author
|
Sweet.. happy for you to fix to and land my PRs any time :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For options such as
EXPORTED_FUNCTIONSthat take lists we now supporta simple file format that is just one line per symbol. It doesn't
require any escaping or punctuation.
This is much easier to use and maintain and is in line with other compiler
toolchain options used by gcc and ld. For example ld's
--retain-symbols-file=filenameor wasm-ld's--undefined-file=filename.This should be especially useful for options like
ASYNCIFY_ADDorASYNCIFY_REMOVEwhich often involve a lot of quoting (because theyinclude things like spaces and commas).