Repository navigation
ssl: Stop the sender socket side if error - #10011
Merged
Merged
Conversation
When socket reports an error close down the socket sender process to avoid trying to send something else.
Contributor
CT Test Results 2 files 66 suites 26m 18s ⏱️ Results for commit e4a66c1. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts
// Erlang/OTP Github Action Bot |
dgud
force-pushed
the
dgud/ssl/close-sender/OTP-19694
branch
from
July 3, 2025 14:33
b91746e to
de506f6
Compare
IngelaAndin
previously approved these changes
Jul 4, 2025
dgud
force-pushed
the
dgud/ssl/close-sender/OTP-19694
branch
from
July 4, 2025 08:48
de506f6 to
b2a2e8b
Compare
Socket needs to bind address before connection, make sure to bind to the correct outgoing address.
dgud
force-pushed
the
dgud/ssl/close-sender/OTP-19694
branch
from
July 4, 2025 09:08
b2a2e8b to
e4a66c1
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR ensures that when a socket error occurs, the sender process shuts down, and it also adds the ability to bind an explicit outbound port for TCP/TLS connections.
- Extracts and applies a user-specified
portoption viaget_port/1intls_socket_tcp. - Updates
tls_senderstate machine to always invokedeath_row_shutdownon errors. - Adds outbound port binding in
inet_epmd_tls_socketbefore connecting.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| lib/ssl/src/tls_socket_tcp.erl | Added get_port/1 to capture outbound port and passed a BindAddr map through connect_1. |
| lib/ssl/src/tls_sender.erl | Unified error handling to always call death_row_shutdown and removed special-case branches. |
| lib/ssl/src/inet_epmd_tls_socket.erl | Introduced BindAddress construction and bound the socket to it before connect. |
Comments suppressed due to low confidence (4)
lib/ssl/src/tls_socket_tcp.erl:320
- Consider adding a brief @SPEC and doc comment for
get_port/1to explain the returned tuple{OutPort, Opts}and how theportoption is consumed.
get_port(Opts0) ->
lib/ssl/src/tls_sender.erl:573
- The new unified error clause always triggers
death_row_shutdown; add or update comments to clarify that non-distribution errors also intentionally shut down the sender.
{error, _} = Error ->
lib/ssl/src/tls_sender.erl:573
- There are no new tests covering the unified shutdown behavior on errors; please add unit/integration tests to verify that the sender process stops as expected for both distribution and non-distribution errors.
{error, _} = Error ->
lib/ssl/src/tls_sender.erl:741
- The
send_post_handshake_data/…case now only handlesokand{error, Reason}; verify that no other return shapes can occur to prevent an unhandled clause runtime crash.
{error, Reason} ->
u3s
approved these changes
Jul 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When socket reports an error close down the socket sender process to avoid trying to send something else.