Repository navigation
ci: declare least-privilege workflow-level contents: read - #20
Merged
lumirlumir merged 2 commits intoJun 19, 2026
Merged
Conversation
Declares an explicit workflow-level permissions: contents: read on 2 workflows that currently inherit the default broad read-write GITHUB_TOKEN. Each file was inspected and only reads the checkout; none publish, push, or write via the GitHub API. Post-CVE-2025-30066 hardening default. Signed-off-by: Arpit Jain <[email protected]>
lumirlumir
requested changes
Jun 2, 2026
lumirlumir
left a comment
Member
There was a problem hiding this comment.
I’ve left two minor formatting suggestions for consecutive blank lines. Otherwise, LGTM.
|
|
||
| workflow_dispatch: | ||
|
|
||
|
|
| - opened | ||
| - reopened | ||
|
|
||
|
|
Member
|
@arpitjain099 Are you still available to work on this PR? |
Contributor
Author
Sorry got busy, please give me 1hr |
Signed-off-by: arpitjain099 <[email protected]>
Contributor
Author
|
Done, removed the extra blank line in both files. |
2 of 3 tasks
This was referenced Jul 17, 2026
2 of 3 tasks
2 of 3 tasks
This was referenced Sep 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hardens 2 workflow(s) in this repo by declaring a workflow-level
permissions: contents: read. Today those workflows inherit the legacy broad read-write GITHUB_TOKEN; the read-only default reduces blast radius if any step is compromised.I checked each file - they read the checkout and run tests/lints; no GitHub API writes (no
gh pr/issue, nogit push, no release/publish/comment actions). So behavior is unchanged.Reference: the tj-actions/changed-files compromise (CVE-2025-30066) is the canonical reason to apply least-privilege defaults.