WIP: Socket.io v3 by HMarzban · Pull Request #4916 · ether/etherpad

HMarzban · 2021-03-03T11:27:37Z

No description provided.

Bump fork

…nto develop

… develop

JohnMcLear · 2021-03-03T11:28:37Z

Excited to watch the tests run 👯‍♀️

lgtm-com · 2021-03-03T11:33:09Z

This pull request introduces 1 alert when merging 2d08f62 into 0aad3b7 - view on LGTM.com

new alerts:

1 for Unneeded defensive code

JohnMcLear

Btw, you can use "draft" pull requests for WIP things :)

JohnMcLear · 2021-03-03T11:33:10Z

  </script>

-  <script type="text/javascript" src="../socket.io/socket.io.js?v=<%=settings.randomVersionString%>"></script>
+  <script type="text/javascript" src="../socket.io/socket.io.js"></script>


This should not be here :)

Unfortunately I had to remove the random version tag by force, otherwise the socket.io client script would not load!

HMarzban · 2021-03-03T11:40:46Z

If setting.loadTest: true, in most cases the test will fail! ( webaccess issue)
The userCanModify and checkAccess functions in /hooks/express/webaccess.js file, need to modify!

Also, websocket, chat, etc. tests passed successfully! But on the client side, when the user makes new changes, the other client will not receive new changes! (This is the main issue right now)

lgtm-com · 2021-03-03T11:59:00Z

This pull request introduces 1 alert when merging e1d8b41 into 0aad3b7 - view on LGTM.com

new alerts:

1 for Unneeded defensive code

HMarzban · 2021-03-03T12:03:07Z

From now on, we have to set the transports option on the client and server to io.connect (opt)!
(This branch; src/node/hooks/express/socketio.js:73)

In this case we must have to put settings.socketTransportProtocols in clientVars for "pad.html" (and where necessary) when it's render in the back-end.

… feat/socket3

JohnMcLear · 2021-03-03T21:14:49Z

If setting.loadTest: true, in most cases the test will fail! ( webaccess issue)
The userCanModify and checkAccess functions in /hooks/express/webaccess.js file, need to modify!

Also, websocket, chat, etc. tests passed successfully! But on the client side, when the user makes new changes, the other client will not receive new changes! (This is the main issue right now)

This is because the tests mostly don't cover real time collaboration, this is something I'm working on at the moment :)

lgtm-com · 2021-03-04T05:02:43Z

This pull request introduces 1 alert when merging 7fc14d7 into 912f0f1 - view on LGTM.com

new alerts:

1 for Unneeded defensive code

HMarzban · 2021-03-04T05:05:33Z

Well, let me drop the mic, the real time collaboration issue was resolved. work like magic ⚔🧝‍♂️

If setting.loadTest: true, in most cases the test will fail! ( webaccess issue)
The userCanModify and checkAccess functions in /hooks/express/webaccess.js file, need to modify!
Also, websocket, chat, etc. tests passed successfully! But on the client side, when the user makes new changes, the other client will not receive new changes! (This is the main issue right now)

This is because the tests mostly don't cover real time collaboration, this is something I'm working on at the moment :)

lgtm-com · 2021-03-04T07:46:47Z

This pull request introduces 1 alert when merging 2f4ef59 into 912f0f1 - view on LGTM.com

new alerts:

1 for Unneeded defensive code

lgtm-com · 2021-03-04T07:52:38Z

This pull request introduces 1 alert when merging 5b4c1d9 into 912f0f1 - view on LGTM.com

new alerts:

1 for Unneeded defensive code

… feat/socket3

lgtm-com · 2021-03-05T15:37:03Z

This pull request introduces 1 alert when merging b39e041 into 4ca989a - view on LGTM.com

new alerts:

1 for Unneeded defensive code

lgtm-com · 2021-03-05T15:53:51Z

This pull request introduces 1 alert when merging 5396be1 into 4ca989a - view on LGTM.com

new alerts:

1 for Unneeded defensive code

This might be reverted, depending on what happens.

lgtm-com · 2021-03-06T09:28:38Z

This pull request introduces 1 alert when merging 6af8564 into 4044860 - view on LGTM.com

new alerts:

1 for Unneeded defensive code

… feat/socket3

HMarzban · 2021-04-08T05:50:12Z

I was reading this changeset recently:
https://socket.io/blog/monthly-update-3/#Socket-IO-v4

If we do this migration, The road is paved for us for further upgrades

lgtm-com · 2021-04-08T05:52:28Z

This pull request introduces 2 alerts when merging 2e29f23 into a796811 - view on LGTM.com

new alerts:

1 for Unused variable, import, function or class
1 for Unneeded defensive code

HMarzban · 2021-04-08T06:03:02Z

@webzwo0i Sorry to be late for comments, I was in vacation.

lgtm-com · 2021-04-08T08:41:58Z

This pull request introduces 1 alert when merging f516d32 into a796811 - view on LGTM.com

new alerts:

1 for Unneeded defensive code

stale · 2021-06-07T11:41:37Z

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

HMarzban · 2021-09-27T21:13:02Z

Hey guys, have you thought about this PR! I have already fixed all the problems related to this upgrade! do you have a socket upgrade plan or is it necessary anymore?
@JohnMcLear
@webzwo0i

rhansen · 2021-09-28T08:53:37Z

Before we can merge this we need to figure out a way to support plugins that expect socket.io 2.x. For example: https://github.com/ether/ep_webrtc/blob/7e5941f4a21ab869a8448ecb771c844643f3ef94/index.js#L46-L48

HMarzban · 2021-09-28T10:37:53Z

It's okay, I can help you! I change this function like below and it works like a charm!

const handleRTCMessage = (socket, client, payload) => {
  // if(!socketIo) return false
  const userId = payload.from;
  const padId = payload.padId;
  const to = payload.to;

  const msg = {
    type: 'COLLABROOM',
    data: {
      type: 'RTC_MESSAGE',
      payload: {
        from: userId,
        to,
        data: payload.data,
      },
    },
  };
  socketIo.to(padId).emit('RTC_MESSAGE', msg);
};

rhansen · 2021-09-30T05:21:22Z

My point is that we need to audit all plugins to determine which ones depend on v2-specific behavior, then update them to work both with and without this PR. Alternatively, change this PR so that the plugins that depend on v2-specific behavior somehow continue to work unchanged.

stale · 2021-11-29T06:13:38Z

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

SamTV12345 · 2024-01-13T20:33:45Z

@HMarzban I know it's been some time since you worked on this pull request. During the last 2.5 years has changed and I am currently the only maintainer of Etherpad. I am looking for help with the upgrade to socket.io v4. So if you find some time it would be awesome if you could help me with the upgrade.
With the help of @JohnMcLear I managed to revive Etherpad, made lots of changes to Etherpad and introduced Typescript to ueberdb. If you prepare a pull request you can be sure that it will be merged. I normally answer in at most one day.

So TDLR: It would be awesome if you could help me with the socket io v4 upgrade.

HMarzban · 2024-01-14T15:17:53Z

Hi, @SamTV12345

Thank you for reaching out and for keeping Etherpad thriving! It's great to hear about the progress and the introduction of TypeScript to ueberdb.

I'm excited to help with the socket.io v4 upgrade.
(It was a quick, challenging experience last time, but I did it and it worked!)

However, I'm currently swamped with tasks and will be busy until the 2nd of February. But right after that, I'm all in!
I'm looking forward to diving back into the wavy, turbulent ocean of Etherpad code and exploring the best paths for the upgrade.
(I appreciate your patience.)

SamTV12345 · 2024-01-14T15:21:51Z

Hi, @SamTV12345

Thank you for reaching out and for keeping Etherpad thriving! It's great to hear about the progress and the introduction of TypeScript to ueberdb.

I'm excited to help with the socket.io v4 upgrade. (It was a quick, challenging experience last time, but I did it and it worked!)

However, I'm currently swamped with tasks and will be busy until the 2nd of February. But right after that, I'm all in! I'm looking forward to diving back into the wavy, turbulent ocean of Etherpad code and exploring the best paths for the upgrade. (I appreciate your patience.)

Thanks for the help. This is very much appreciated. Yeah the Etherpad code with its hundreds of public methods is a bit overwhelming at least for me. So any help is awesome. Sure it is not a problem if you are currently busy. So until February and thanks for reporting back.

SamTV12345 · 2024-02-29T11:52:04Z

I guess we can finally close this <3

HMarzban added 4 commits October 6, 2020 10:53

Merge pull request #2 from ether/develop

d7437b1

Bump fork

Merge branch 'develop' of https://github.com/HMarzban/etherpad-lite i…

1414004

…nto develop

Merge branch 'develop' of https://github.com/ether/etherpad-lite into…

2315312

… develop

feat: migration socket v2 -> v3

2d08f62

JohnMcLear reviewed Mar 3, 2021

View reviewed changes

fix: lint, modify

e1d8b41

HMarzban added 2 commits March 3, 2021 17:40

Merge branch 'develop' of https://github.com/ether/etherpad-lite into…

3ed2ea6

… feat/socket3

fix: timeslider socket script load

b2323d8

fix: getRoomSockets

7fc14d7

Update load-test.yml

2f4ef59

Update load-test.yml

5b4c1d9

HMarzban added 3 commits March 5, 2021 16:11

Merge branch 'develop' of https://github.com/ether/etherpad-lite into…

ea3490a

… feat/socket3

merge to 1.8.12

8b6dfdb

fix: admin panel socket middleware

b39e041

modify

5396be1

100 author test

6af8564

This might be reverted, depending on what happens.

Update load-test.yml

4db1910

HMarzban added 3 commits April 8, 2021 09:23

Merge branch 'develop' of https://github.com/ether/etherpad-lite into…

d422f01

… feat/socket3

remove accessStatus

67732e2

remove apdId in sendMessage fn

2e29f23

remove accessStatus

f516d32

stale Bot added the wontfix Wont Fix these things, no hate. label Jun 7, 2021

stale Bot closed this Jun 14, 2021

rhansen mentioned this pull request Aug 9, 2021

Etherpad keeps reconnecting after pasting large text #4951

Closed

rhansen reopened this Sep 28, 2021

stale Bot removed the wontfix Wont Fix these things, no hate. label Sep 28, 2021

stale Bot added the wontfix Wont Fix these things, no hate. label Nov 29, 2021

stale Bot closed this Dec 7, 2021

SamTV12345 removed the wontfix Wont Fix these things, no hate. label Jan 13, 2024

SamTV12345 reopened this Jan 13, 2024

HMarzban mentioned this pull request Feb 11, 2024

Migrate Socket.IO from Version 2 to Version 3 🚀 #6152

Merged

HMarzban mentioned this pull request Feb 25, 2024

Revise transport Socket.io@3/4 #6188

Merged

SamTV12345 closed this Feb 29, 2024

Conversation

HMarzban commented Mar 3, 2021

Uh oh!

JohnMcLear commented Mar 3, 2021

Uh oh!

lgtm-com Bot commented Mar 3, 2021

Uh oh!

JohnMcLear left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

JohnMcLear Mar 3, 2021

Choose a reason for hiding this comment

Uh oh!

HMarzban Mar 3, 2021

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

HMarzban commented Mar 3, 2021

Uh oh!

lgtm-com Bot commented Mar 3, 2021

Uh oh!

HMarzban commented Mar 3, 2021

Uh oh!

JohnMcLear commented Mar 3, 2021

Uh oh!

lgtm-com Bot commented Mar 4, 2021

Uh oh!

HMarzban commented Mar 4, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lgtm-com Bot commented Mar 4, 2021

Uh oh!

lgtm-com Bot commented Mar 4, 2021

Uh oh!

lgtm-com Bot commented Mar 5, 2021

Uh oh!

lgtm-com Bot commented Mar 5, 2021

Uh oh!

lgtm-com Bot commented Mar 6, 2021

Uh oh!

HMarzban commented Apr 8, 2021

Uh oh!

lgtm-com Bot commented Apr 8, 2021

Uh oh!

HMarzban commented Apr 8, 2021

Uh oh!

lgtm-com Bot commented Apr 8, 2021

Uh oh!

stale Bot commented Jun 7, 2021

Uh oh!

HMarzban commented Sep 27, 2021

Uh oh!

rhansen commented Sep 28, 2021

Uh oh!

HMarzban commented Sep 28, 2021

Uh oh!

rhansen commented Sep 30, 2021

Uh oh!

stale Bot commented Nov 29, 2021

Uh oh!

SamTV12345 commented Jan 13, 2024

Uh oh!

HMarzban commented Jan 14, 2024

Uh oh!

SamTV12345 commented Jan 14, 2024

Uh oh!

SamTV12345 commented Feb 29, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

HMarzban commented Mar 4, 2021 •

edited

Loading