This repository was archived by the owner on Dec 14, 2021. It is now read-only.
Repository navigation
This repository was archived by the owner on Dec 14, 2021. It is now read-only.
Update getTransactionSuccess to decode logs #28
Description
Activity
- Great idea! Would you like to make a pr ;)…Sent from my iPhoneOn May 1, 2018, at 9:30 PM, Paul Fletcher-Hill ***@***.***> wrote: Update getTransactionSuccess method to optionally decode logs Issue Type Bug (https://github.com/ethjs/ethjs/blob/master/.github/CONTRIBUTING.md#bug-reports) Feature (https://github.com/ethjs/ethjs/blob/master/.github/CONTRIBUTING.md#feature-requests) Description The getTransactionSuccess method is helpful, but I'd like it to be able to decode returned logs as well. The method could either take as argument an ABI or could be added as a method to a contract instance (i.e. contractInstance.getTransactionSuccess("<txHash>")). I've found myself creating a log decoder (i.e. const decoder = Eth.abi.logDecoder(<ABI>)) and running logs returned via getTransactionSuccess through that decoder, and it would be nice to have the method do that for me. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.
Sure thing. Will open one by this weekend!
Update getTransactionSuccess method to optionally decode logs
Issue Type
Description
The
getTransactionSuccessmethod is helpful, but I'd like it to be able to decode returned logs as well. The method could either take as argument an ABI or could be added as a method to a contract instance (i.e.contractInstance.getTransactionSuccess("<txHash>")).I've found myself creating a log decoder (i.e.
const decoder = Eth.abi.logDecoder(<ABI>)) and running logs returned viagetTransactionSuccessthrough that decoder, and it would be nice to have the method do that for me.