Unable to write tests for events when using Solidity Events

The convention when writing Solidity Smart Contracts is to capitalize events (http://solidity.readthedocs.io/en/develop/structure-of-a-contract.html#events) aka

contract SimpleAuction {
    event HighestBidIncreased(address bidder, uint amount); // Event

    function bid() payable {
        // ...
        HighestBidIncreased(msg.sender, msg.value); // Triggering event
    }
}

Such a contract will generate a javascript function that will appear as

SimpleAuction.HighestBidIncreased

But if you try to use the ABI when writing tests for ethjs, you will anger ESLint with the error:

A function with a name starting with an uppercase letter should only be used as a constructor  ne
w-cap

The workaround is to write solidity contracts with events starting with a lower case character, which isn't ideal if there are linting constraints introduced in Solidity which force uppercase event names.

That feels like a bug in the linter. The linter shouldn't be complaining when a method with capital first letter is called, it should be complaining when such a method is declared. Otherwise the linter will complain about the output of third party libraries (like in this case).

This seems to be linting related yes. I can shut off that setting within the linter for EthJS proper.

you can disable the line for your event with // eslint-disable-line

It is the solidity linter, not EcmaScript linter. Though, Solidity did also just add disabling linting via comments as well, but I don't know the comment off-hand.

Not much I can do here, although Mike, I'm considering dropping callbacks. Just for you of course ;)

…

Sent from my iPhone

On Dec 12, 2017, at 7:18 PM, Micah Zoltu ***@***.***> wrote: It is the solidity linter, not EcmaScript linter. Though, Solidity did also just add disabling linting via comments as well, but I don't know the comment off-hand. — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

Navigation Menu

Repository navigation

Unable to write tests for events when using Solidity Events #7

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Unable to write tests for events when using Solidity Events #7

Description

Activity

MicahZoltu commented on Oct 7, 2017

SilentCicero commented on Nov 3, 2017

SupremeTechnopriest commented on Dec 12, 2017

MicahZoltu commented on Dec 13, 2017

SilentCicero commented on Dec 13, 2017

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions