This repository was archived by the owner on Dec 14, 2021. It is now read-only.
Repository navigation
added broken test and supporting .sol and .json - #5
Open
pointtoken wants to merge 1 commit into
Open
pointtoken wants to merge 1 commit into
pointtoken wants to merge 1 commit into
Conversation
|
part of the question here is what is from this PRs commented failing test: const addEventWeb3 = SampleMathContractInstanceWeb3.addEvent({ a: 5 }, { fromBlock: 0, toBlock: 'latest' });
const addEvent = SampleMathContractInstance.addEvent({ a: 5 }, { fromBlock: 0, toBlock: 'latest' });
assert.equal(addEvent.options, addEventWeb3.options); |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Kumavis suggested I submit a PR with a broken test. That was a little tricky, since your policy doesn't allow commits with broken tests, so you'll have to rem back in the code to get it to fail. I went ahead and checked in the Solidity file. The json abi was generated with Truffle.