Skip to content

Release Proposal 2.2.1 #644

Closed
Closed

Description

@Phillip9587

What changed

  • refactor: move common request validation to read function
  • deps:
    • type-is@^2.0.1
    • iconv-lite@^0.7.0
    • raw-body@^3.0.1
    • debug@^4.4.3

Additionally, I’d like to include #642 to update debug to ^4.4.3 to force users to update from the compromised 4.4.2 version. Edit: #642 already merged

The critical change here is the iconv-lite update to 0.7.0, which addresses important issues.

A new release is needed to deduplicate iconv-lite in our dependency tree (see npmgraph). Currently, two versions of iconv-lite are being pulled in. Since iconv-lite is pre-1.0.0, semver treats ^0.6.3 like ~0.6.3 (it matches only 0.6.x), so it won’t float to 0.7.0. Releasing with iconv-lite@^0.7.0 lets npm dedupe our tree to a single 0.7.x.

Activity

  1. added theissue type on Oct 3, 2025
  2. Phillip9587 commented on Oct 3, 2025

    @Phillip9587
    MemberAuthor
  3. jonchurch commented on Oct 15, 2025

    @jonchurch
    Member

    I was paying special attention to the iconv-lite changes in 0.7.0. The changes are for utf8 encoding and body-parser is only using decode. So no impact 👍

    This RC looks good to me @Phillip9587

    I'll give some time for @UlisesGascon to chime in, but this looks good to me and we can publish it asap otherwise.

  4. Phillip9587 commented on Oct 15, 2025

    @Phillip9587
    MemberAuthor

    We should include #648 to avoid potential performance regressions. It was missed in #600.

  5. bjohansebas commented on Oct 16, 2025

    @bjohansebas
    Member

    The only change that affects body-parser is pillarjs/iconv-lite#328; the rest of the changes are not important for body-parser and its support.

  6. Phillip9587 commented on Oct 25, 2025

    @Phillip9587
    MemberAuthor

    Hey @jonchurch @UlisesGascon, can we please merge #648 and publish the release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions