Repository navigation
[Backport 5.x] perf: reduce content-type parser overhead - #7019
Merged
Merged
Conversation
This PR does 2 things: * Replace AsyncResource.bind() with a callback that still preserves async scope (this is an optimization I've seen in Node.js, I believe by @mcollina) * Cache parameterized content-type parser matches ```sh Existing command Before After Change ━━━━━━━━━━━━━━━━━━━━━━━━━━ ━━━━━━━━━━━━━━━ ━━━━━━━━━━━━━━━ ━━━━━━━━ npm run benchmark:parser 123,106 req/s 161,468 req/s +31.2% ────────────────────────── ─────────────── ─────────────── ──────── npm run benchmark 201,041 req/s 201,310 req/s +0.13% ``` Signed-off-by: Gürgün Dayıoğlu <[email protected]> (cherry picked from commit d1dd890)
Member
|
It means that the published package also have wrong version number. |
Member
|
@climba03003 yes, should we not include this fix in the PR? We need to fix it either here or with a separate commit |
gurgunday
previously approved these changes
Sep 11, 2026
Member
Synced the version and published new version. |
climba03003
force-pushed
the
backport-7012-to-5.x
branch
from
September 11, 2026 09:21
700f09f to
8159935
Compare
climba03003
approved these changes
Sep 11, 2026
metcoder95
approved these changes
Sep 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport d1dd890 from #7012.