Repository navigation
[FirebasAuth] added that Errors are thrown via a PlatformException - #146
Merged
Merged
Conversation
Contributor
|
@escamoteur what's the status on this? This bug is pretty frustrating to deal with, especially combined with the fact that Flutter doesn't seem to print native error logs to the console anymore. Can we close this so as not to deter others from opening a PR to fix it? this is now months old. |
Contributor
Author
|
@KevinTheGray I only made an addition to the docs. You should get Platformexecptions right noww. |
kroikie
force-pushed
the
add_errhandling_to_readme
branch
from
July 2, 2020 04:46
0a05659 to
db1f94c
Compare
Contributor
|
@escamoteur Thanks for the PR. Sorry for taking so long to get to it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When I started with FirebaseAuth I was puzzled how I access possible error code because exceptions get easily swallowed in an async function.
I added a paragraph to the readme and to the code comments to make it easier for people just starting with Firebase and Flutter
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?