Skip to content

[FirebasAuth] added that Errors are thrown via a PlatformException - #146

Merged
kroikie merged 2 commits into
firebase:masterfrom
escamoteur:add_errhandling_to_readme
Jul 2, 2020
Merged

kroikie merged 2 commits into
firebase:masterfrom
escamoteur:add_errhandling_to_readme

Conversation

@escamoteur

Copy link
Copy Markdown
Contributor

Description

When I started with FirebaseAuth I was puzzled how I access possible error code because exceptions get easily swallowed in an async function.
I added a paragraph to the readme and to the code comments to make it easier for people just starting with Firebase and Flutter

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • [ x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • [ x] If the pull request affects only one plugin, the PR title starts with the name of the plugin in brackets (e.g. [cloud_firestore])
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See [Contributor Guide]).
  • All existing and new tests are passing.
  • [ x] I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the [Flutter Style Guide].
  • [ x] The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy].
  • I updated CHANGELOG.md to add a description of the change.
  • [ x] I signed the [CLA].
  • [ x] I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • [x ] No, this is not a breaking change.

@KevinTheGray

KevinTheGray commented Mar 17, 2020 •

Copy link
Copy Markdown
Contributor

@escamoteur what's the status on this? This bug is pretty frustrating to deal with, especially combined with the fact that Flutter doesn't seem to print native error logs to the console anymore.

Can we close this so as not to deter others from opening a PR to fix it? this is now months old.

@escamoteur

Copy link
Copy Markdown
Contributor Author

@KevinTheGray I only made an addition to the docs. You should get Platformexecptions right noww.

@kroikie
kroikie force-pushed the add_errhandling_to_readme branch from 0a05659 to db1f94c Compare July 2, 2020 04:46
@kroikie

kroikie commented Jul 2, 2020

Copy link
Copy Markdown
Contributor

@escamoteur Thanks for the PR. Sorry for taking so long to get to it.

@kroikie
kroikie merged commit fa18568 into firebase:master Jul 2, 2020
@firebase firebase locked and limited conversation to collaborators Aug 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants