Skip to content

fix(data_connect): exclude generated protobuf sources from analysis - #18687

Merged
Lyokone merged 1 commit into
mainfrom
fix/data-connect-analyze-generated
Sep 14, 2026
Merged

Lyokone merged 1 commit into
mainfrom
fix/data-connect-analyze-generated

Conversation

@Lyokone

@Lyokone Lyokone commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

Description

protobuf 6.1.0 (published 2026-09-11) deprecated create in favour of the
Struct() / ListValue() / Duration() constructors. firebase_data_connect
depends on protobuf: ^6.0.0, so CI resolves 6.1.0 and the checked-in generated
.pb.dart sources emit 7 deprecated_member_use infos. dart analyze --fatal-infos turns those into a hard failure, so the analyze job is red on
every PR opened since 2026-09-11.

Generated protobuf sources aren't hand-maintained, so they're now excluded from
analysis — matching what the sibling example package already does for
lib/generated/**, and what the format job already does via
--ignore "**/generated/**".

Breaking Change

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@gemini-code-assist

Copy link
Copy Markdown
Contributor
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

@Lyokone
Lyokone merged commit 82ac5ff into main Sep 14, 2026
36 checks passed
@Lyokone
Lyokone deleted the fix/data-connect-analyze-generated branch September 14, 2026 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants