Repository navigation
[cloud_firestore] Catch exceptions for transactions on Android - #84
Merged
collinjackson merged 2 commits intoSep 4, 2019
Merged
collinjackson merged 2 commits into
collinjackson merged 2 commits into
Conversation
creativecreatorormaybenot
requested review from
collinjackson and
kroikie
as code owners
September 3, 2019 21:58
collinjackson
approved these changes
Sep 3, 2019
collinjackson
left a comment
collinjackson
left a comment
Contributor
There was a problem hiding this comment.
Looks good! Thank you.
Contributor
Author
14 tasks done
|
has this been released? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should resolve #70.
I assume that the
RuntimeExceptions I am seeing there happen in thedoInBackgroundAsyncTaskofTransaction#set, which is why I added atry-catchblock there.Transaction#updateandTransaction#getalready hadtry-catchblocks, however, they only caughtIllegalStateException's and since I gotRuntimeExceptions and there is no need to be specific about the type of exception when onlye.getMessageis called anyway, I generalized thecatchblock for those as well.Additionally, I applied the same logic to
Transaction#delete, just to be consistent.