New features for admin users list by davwheat · Pull Request #2998 · flarum/framework

davwheat · 2021-07-31T23:58:01Z

Fixes #3742

Changes proposed in this pull request:

Add new features to the ACP users list:

First/Last page buttons
Ability to go direct to a page number
Permalinks to any page via ?page=xxx, and button to copy a permalink to the current page
Add display name column
Add email confirmation status and toggle (requires Add ability to set email confirmation state to false #2997)
User creation
Search
Sorting

Reviewers should focus on:

Screenshot

4uCxmzgf.mp4

Confirmed

Frontend changes: tested on a local Flarum installation.

Ralkage · 2021-08-07T05:40:11Z

LOVE IT ♥ for the table column names, could we have it so that the first letter of each word is capitalized? (e.g. Display Name, Email Confirmed, etc).

Edit: I would also suggest doing the same for the rest of the text on that page including the modal title to keep with the same consistency as the rest of the forum.

Examples:
Create New User
Go to Page
Create Link to Page 45

askvortsov1 · 2021-08-15T15:07:47Z

This PR is getting a bit large. Maybe let's do searching and sorting in follow-ups?

davwheat · 2021-08-15T15:50:15Z

Good idea. I don't think I'll have time to do them soon anyway with the accessibility issues.

Some of the changes (itemlists) make it easier than ever for an extension to modify the userlist to add search and sort, too :P

clarkwinkelmann · 2021-08-21T00:31:28Z

I have not followed the progress here but if I may make a suggestion, could we make the display name column into the link to the user profile?

I'm creating an extension that hides the username from everywhere, so in my extension I added a display name column that becomes the link. I see this PR will add the same column, but it wouldn't be a link.

Or the profile link could be an action of its own instead of being one of the data columns.

SychO9 · 2021-08-21T07:22:34Z

I'm creating an extension that hides the username from everywhere

Btw, there's an issue in core for 1.1 where we will end up having usernames completely hidden from the frontend unless the actor has edit credentials permission (https://github.com/flarum/core/issues/1734).

askvortsov1 · 2021-08-26T04:42:58Z

Will review once rebased.

davwheat · 2021-09-10T16:05:19Z

Rebased!

davwheat · 2021-09-10T16:06:26Z

Ugh VS Code formatted the locale yml... On it

askvortsov1

What are your thoughts on potentially using a shared "PaginatedListState" for tables, actually paginated lists, and infinite scroll lists? It could be handy, but it could also be overengineering I suppose.

askvortsov1 · 2021-09-10T17:41:05Z

+  content() {
+    const fields = this.fields().toArray();
+
+    console.log(this.state);


Seems left over

askvortsov1 · 2021-09-10T17:41:36Z

+/**
+ * A Modal that allows admins to create a new user.
+ */
+export default class CreateUserModal extends Modal {


Is there any way we could use the same component for the Create and Edit modals?

askvortsov1 · 2021-11-08T21:39:05Z

+    return items;
+  }
+
+  private twoWayLinkAttrs(key: keyof typeof this.state, valueName: string = 'value', eventName: string = 'oninput') {


This seems overly complex

askvortsov1 · 2021-11-08T21:40:21Z

+      const indexOfSearch = location.hash.indexOf('?') + 1;
+      const search = indexOfSearch >= 0 ? location.hash.substr(indexOfSearch) : '';
+
+      const params = new URLSearchParams(search);


I wonder if it might make sense to store this info in params namespaced by a table ID. That way, we could support having multiple tables on the same page, and also keep this logic in the table component.

Alternatively, we could support both modes, but error if more than one table / paginated list tries to use non-namespaced-mode?

askvortsov1 · 2022-03-16T19:30:34Z

Hello, thank you for your pull request! In order to speed up future development, keep all work in one place, and take advantage of CI tools that can help us avoid breaking changes, we have moved all Flarum code to a single monorepo at flarum/framework. You can read more about this process in our dev diary. Unfortunately, pull requests can't be carried over to the monorepo, so we have to close all open pull requests. If this pull request is still relevant, please feel free to reopen it over on the monorepo. We apologize for the inconvenience, and hope you will consider contributing to Flarum again in the future.

Eldenroot · 2022-05-17T19:03:25Z

Please rebase it :)

jslirola · 2022-09-13T18:14:58Z

Have these improvements been abandoned or is it possible to continue the progress of them? I think it would be great to implement them in future versions of the core.

I'm not sure if this is the proper place or the official forum to ask it.

SychO9 · 2022-09-13T18:18:03Z

This is planned to be picked up again, can't say when that could be.

jslirola · 2022-09-13T18:22:09Z

Thanks for the quick response, I'm glad to know that this has not been forgotten. :)

umutcandev · 2023-01-27T00:03:15Z

Sorry to revive the thread, it's been quite a while since September. Will there be any progress?

umutcandev · 2024-11-28T23:37:17Z

Being able to search and sorting would be great in the new version. What do you think?

davwheat self-assigned this Jul 31, 2021

davwheat added this to the 1.1 milestone Aug 1, 2021

davwheat force-pushed the dw/2988-user-list-upgrades branch from 536a41f to 477b8e1 Compare August 1, 2021 12:32

davwheat added the type/feature label Aug 1, 2021

davwheat marked this pull request as ready for review August 15, 2021 15:50

askvortsov1 changed the base branch from master to dw/adminpage-ts-rewrite August 21, 2021 01:08

Base automatically changed from dw/adminpage-ts-rewrite to master August 23, 2021 00:59

davwheat force-pushed the dw/2988-user-list-upgrades branch from 8501868 to d43b72f Compare September 10, 2021 16:05

askvortsov1 modified the milestones: 1.1, 1.2 Sep 28, 2021

askvortsov1 self-requested a review October 14, 2021 18:42

askvortsov1 suggested changes Nov 8, 2021

View reviewed changes

davwheat modified the milestones: 1.2, 2.0 Dec 21, 2021

davwheat added 8 commits December 27, 2021 20:07

Add "Go to page" option

dcbb85a

Add first and last page buttons

c308f1c

Refactor total user count out of content function

3f9a38d

Add page permalinks

22c4a9d

Add display name column

ad9bd82

Add email confirmation visualisation

a9cb352

Move infoHeader children to ItemList function; add missing translation

5bea4ed

Add ability to create new user from Users List page

f94eb07

Unformat locale yml

495e9a5

davwheat force-pushed the dw/2988-user-list-upgrades branch from 0fd5350 to 495e9a5 Compare December 27, 2021 19:10

askvortsov1 removed this from the 2.0 milestone Mar 10, 2022

askvortsov1 closed this Mar 16, 2022

This was referenced Feb 21, 2023

feat: add display name column to admin users list #3740

Merged

feat: improved page navigation for users list #3741

Merged

feat: add user creation to users list page #3744

Merged

SychO9 deleted the dw/2988-user-list-upgrades branch June 2, 2023 09:07

Conversation

davwheat commented Jul 31, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Ralkage commented Aug 7, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

askvortsov1 commented Aug 15, 2021

Uh oh!

davwheat commented Aug 15, 2021

Uh oh!

clarkwinkelmann commented Aug 21, 2021

Uh oh!

SychO9 commented Aug 21, 2021

Uh oh!

askvortsov1 commented Aug 26, 2021

Uh oh!

davwheat commented Sep 10, 2021

Uh oh!

davwheat commented Sep 10, 2021

Uh oh!

askvortsov1 left a comment

Choose a reason for hiding this comment

Uh oh!

askvortsov1 Sep 10, 2021

Choose a reason for hiding this comment

Uh oh!

askvortsov1 Sep 10, 2021

Choose a reason for hiding this comment

Uh oh!

askvortsov1 Nov 8, 2021

Choose a reason for hiding this comment

Uh oh!

askvortsov1 Nov 8, 2021

Choose a reason for hiding this comment

Uh oh!

askvortsov1 commented Mar 16, 2022

Uh oh!

Eldenroot commented May 17, 2022

Uh oh!

jslirola commented Sep 13, 2022

Uh oh!

SychO9 commented Sep 13, 2022

Uh oh!

jslirola commented Sep 13, 2022

Uh oh!

umutcandev commented Jan 27, 2023

Uh oh!

umutcandev commented Nov 28, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

davwheat commented Jul 31, 2021 •

edited

Loading

Ralkage commented Aug 7, 2021 •

edited

Loading