Repository navigation
systemd: Change ignition-config-delete failure job mode and make OEM mount stricter - #143
Merged
Merged
Conversation
We only expect a disk-based OEM partition to be btrfs or ext4, so don't rely on the `auto` type. Signed-off-by: James Le Cuirot <[email protected]>
systemd itself has not used the isolate job mode for emergency.target since 2013. replace-irreversibly does not proactively stop all the other units, just the ones that would block the new target. This can actually make debugging easier because the system will be in a closer state to the one when the failure occurred. The same change has been made in bootengine. Signed-off-by: James Le Cuirot <[email protected]>
krnowak
reviewed
Apr 15, 2026
krnowak
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
systemd itself has not used the
isolatejob mode foremergency.targetsince 2013.replace-irreversiblydoes not proactively stop all the other units, just the ones that would block the new target. This can actually make debugging easier because the system will be in a closer state to the one when the failure occurred. I am making the same change in bootengine to fix an issue.We only expect a disk-based OEM partition to be btrfs or ext4, so don't rely on the
autotype. This is better for security and probably a smidge faster too.How to use
Just test it boots normally.
Testing done
Jenkins has passed with these changes alongside the other wider changes. I have also done lots of manual testing. These changes are not dependent on the wider changes though.