sysext: add built-in Incus sysext image by tormath1 · Pull Request #1655 · flatcar/scripts

tormath1 · 2024-02-13T12:40:47Z

In this PR, we add Incus support as opt-out built-in sysext.

Note for reviewers:

Most of this PR is adding new packages into portage-stable
One commit must be upstreamed: app-containers/incus: fix cross-compilation issue (app-containers/incus: fix cross-compilation issue gentoo/gentoo#42095)
With this sysext, we're adding new groups and users - I tried to leverage userdb to dynamically load and unload those groups when we load and unload the sysext image (note: it seems a soft reboot might still be necessary)
I have one concern for the static-libs useflag enabled for sys-libs/libcap as it seems we don't use this flag for the generic image but for the SDK - that said, the CI output does not show any change regarding the libcap.
documentation: incus: initial documentation flatcar-website#423

How to use

(This is optional to use ZFS)

---
variant: flatcar
version: 1.1.0
storage:
  files:
    - path: /etc/flatcar/enabled-sysext.conf
      contents:
        inline: |
          incus
          zfs
  links:
    - path: /etc/extensions/docker-flatcar.raw
      target: /dev/null
      overwrite: true
    - path: /etc/extensions/containerd-flatcar.raw
      target: /dev/null
      overwrite: true

Once on the instance, you can use a preseed or follow the interactive incus admin init:

core@localhost ~ $ systemctl status incus
● incus.service - Incus - main daemon
     Loaded: loaded (/usr/lib/systemd/system/incus.service; indirect; preset: disabled)
     Active: active (running) since Thu 2025-05-15 07:54:30 UTC; 40s ago
...
core@localhost ~ $ incus admin init
core@localhost ~ $ incus launch images:ubuntu/22.04 ubuntu-01
Launching ubuntu-01
core@localhost ~ $ incus list
+-----------+---------+----------------------+------+-----------+-----------+
|   NAME    |  STATE  |         IPV4         | IPV6 |   TYPE    | SNAPSHOTS |
+-----------+---------+----------------------+------+-----------+-----------+
| ubuntu-01 | RUNNING | 10.126.29.162 (eth0) |      | CONTAINER | 0         |
+-----------+---------+----------------------+------+-----------+-----------+
core@localhost ~ $ incus exec ubuntu-01 cat /etc/os-release
PRETTY_NAME="Ubuntu 22.04.5 LTS"
NAME="Ubuntu"
VERSION_ID="22.04"
VERSION="22.04.5 LTS (Jammy Jellyfish)"
VERSION_CODENAME=jammy
ID=ubuntu
ID_LIKE=debian
HOME_URL="https://www.ubuntu.com/"
SUPPORT_URL="https://help.ubuntu.com/"
BUG_REPORT_URL="https://bugs.launchpad.net/ubuntu/"
PRIVACY_POLICY_URL="https://www.ubuntu.com/legal/terms-and-policies/privacy-policy"
UBUNTU_CODENAME=jammy
core@localhost ~ $ incus storage list
+---------+--------+-------------+---------+---------+
|  NAME   | DRIVER | DESCRIPTION | USED BY |  STATE  |
+---------+--------+-------------+---------+---------+
| default | zfs    |             | 3       | CREATED |
+---------+--------+-------------+---------+---------+
core@localhost ~ $ zpool list
NAME      SIZE  ALLOC   FREE  CKPOINT  EXPANDSZ   FRAG    CAP  DEDUP    HEALTH  ALTROOT
default  4.50G   264M  4.24G        -         -     1%     5%  1.00x    ONLINE  -

CI: http://jenkins.infra.kinvolk.io:8080/job/container/job/packages_all_arches/5981/cldsv/
Changelog entries added in the respective changelog/ directory (user-facing change, bug fix, security fix, update)
Add new packages to .github/workflows/portage-stable-packages-list
rebase on Build ZFS sysext with each release #1742
review downstream patch (tc-is-cross-compiler) + wait for Go1.21 upgrade (app-containers/incus: fix cross compilation issue gentoo/gentoo#36323)
Inspected CI output for image differences: /boot and /usr size, packages, list files for any missing binaries, kernel modules, config files, kernel modules, etc.
Inspect USE flags

Closes: flatcar/Flatcar#1319

github-actions · 2024-03-13T12:02:14Z

Build action triggered: https://github.com/flatcar/scripts/actions/runs/9052482849

krnowak · 2025-05-16T14:30:04Z

@@ -0,0 +1,3 @@
+cros_pre_src_compile_pkgconfig() {


This looks like a fix candidate for upstream, no?

It's from Gentoo commit 91137d52c4f6307b512c6f447236bc75e8f8b3ec. Signed-off-by: Mathieu Tortuyaux <[email protected]>

Signed-off-by: Mathieu Tortuyaux <[email protected]>

Incus build uses pkg-config support in Go to link against some library. This needs the correct sysroot version of PKG_CONFIG to be exported. Signed-off-by: Jeremi Piotrowski <[email protected]> Co-Authored-By: Mathieu Tortuyaux <[email protected]>

Sort the sysext entries as well. Signed-off-by: Mathieu Tortuyaux <[email protected]>

this is required when loading the sysext image to dynamically load / unload the groups provided by the image. Signed-off-by: Mathieu Tortuyaux <[email protected]>

This requests the `incus.service` for the multi-user.target Signed-off-by: Mathieu Tortuyaux <[email protected]>

Signed-off-by: Mathieu Tortuyaux <[email protected]>

While building on `amd64`: ```bash dosbin: _dist/bin/linux_amd64/incusd does not exist ``` Signed-off-by: Mathieu Tortuyaux <[email protected]>

Signed-off-by: Mathieu Tortuyaux <[email protected]>

tormath1 self-assigned this Feb 13, 2024

tormath1 had a problem deploying to development February 13, 2024 12:40 — with GitHub Actions Error

tormath1 force-pushed the tormath1/exp-incus branch from f116e61 to 09f3036 Compare February 13, 2024 14:04

tormath1 had a problem deploying to development February 13, 2024 14:04 — with GitHub Actions Error

tormath1 force-pushed the tormath1/exp-incus branch from 09f3036 to 635a695 Compare February 14, 2024 10:16

tormath1 commented Feb 14, 2024

View reviewed changes

Comment thread sdk_container/src/third_party/portage-stable/app-containers/lxc/lxc-5.0.3.ebuild Outdated

tormath1 force-pushed the tormath1/exp-incus branch from 635a695 to 7e0fe1a Compare February 14, 2024 14:10

github-actions Bot mentioned this pull request Feb 22, 2024

Monthly contributions report 2024-01-22 - 2024-02-21 flatcar/Flatcar#1369

Closed

pothos reviewed Mar 6, 2024

View reviewed changes

Comment thread ci-automation/base_sysexts.sh Outdated

tormath1 force-pushed the tormath1/exp-incus branch from 7e0fe1a to 849780e Compare March 6, 2024 11:28

tormath1 had a problem deploying to development March 6, 2024 11:28 — with GitHub Actions Error

tormath1 force-pushed the tormath1/exp-incus branch from 849780e to bfe0b2b Compare March 13, 2024 09:14

tormath1 had a problem deploying to development March 13, 2024 09:14 — with GitHub Actions Error

tormath1 commented Mar 13, 2024

View reviewed changes

Comment thread sdk_container/src/third_party/portage-stable/app-containers/incus/incus-0.6-r1.ebuild Outdated

This comment was marked as outdated.

Sign in to view

tormath1 force-pushed the tormath1/exp-incus branch from bfe0b2b to c18d6c2 Compare March 15, 2024 09:27

tormath1 had a problem deploying to development March 15, 2024 09:27 — with GitHub Actions Error

tormath1 force-pushed the tormath1/exp-incus branch from c18d6c2 to accd423 Compare March 27, 2024 16:55

tormath1 had a problem deploying to development March 27, 2024 16:55 — with GitHub Actions Error

tormath1 had a problem deploying to development March 27, 2024 16:56 — with GitHub Actions Error

tormath1 had a problem deploying to development March 28, 2024 09:33 — with GitHub Actions Error

tormath1 force-pushed the tormath1/exp-incus branch from 0e6070a to 257114d Compare March 28, 2024 11:02

tormath1 had a problem deploying to development March 28, 2024 11:02 — with GitHub Actions Error

tormath1 force-pushed the tormath1/exp-incus branch from 257114d to 3bc9670 Compare March 28, 2024 13:54

tormath1 had a problem deploying to development March 28, 2024 13:54 — with GitHub Actions Error

tormath1 force-pushed the tormath1/exp-incus branch from 3bc9670 to fb6a0f2 Compare April 9, 2024 12:50

tormath1 had a problem deploying to development April 9, 2024 12:50 — with GitHub Actions Error

tormath1 had a problem deploying to development April 10, 2024 09:05 — with GitHub Actions Error

tormath1 had a problem deploying to development April 10, 2024 10:45 — with GitHub Actions Error

tormath1 marked this pull request as ready for review May 15, 2025 13:09

tormath1 moved this from ⚒️ In Progress to ✅ Testing / in Review in Flatcar tactical, release planning, and roadmap May 15, 2025

tormath1 requested a review from a team May 15, 2025 13:25

krnowak reviewed May 16, 2025

View reviewed changes

tormath1 and others added 20 commits May 19, 2025 11:24

sys-fs/lxcfs: new package

ce43c81

It's from Gentoo commit 91137d52c4f6307b512c6f447236bc75e8f8b3ec. Signed-off-by: Mathieu Tortuyaux <[email protected]>

dev-util/xdelta: new package

047c57c

It's from Gentoo commit 91137d52c4f6307b512c6f447236bc75e8f8b3ec. Signed-off-by: Mathieu Tortuyaux <[email protected]>

dev-libs/raft: new package

56eda53

It's from Gentoo commit 91137d52c4f6307b512c6f447236bc75e8f8b3ec. Signed-off-by: Mathieu Tortuyaux <[email protected]>

dev-libs/cowsql: new package

dc26fec

It's from Gentoo commit 91137d52c4f6307b512c6f447236bc75e8f8b3ec. Signed-off-by: Mathieu Tortuyaux <[email protected]>

app-containers/lxc: new package

198a214

It's from Gentoo commit 91137d52c4f6307b512c6f447236bc75e8f8b3ec. Signed-off-by: Mathieu Tortuyaux <[email protected]>

acct-user/lxc: new package

284f1c9

It's from Gentoo commit 91137d52c4f6307b512c6f447236bc75e8f8b3ec. Signed-off-by: Mathieu Tortuyaux <[email protected]>

acct-group/lxc

5fd4a23

It's from Gentoo commit 91137d52c4f6307b512c6f447236bc75e8f8b3ec. Signed-off-by: Mathieu Tortuyaux <[email protected]>

acct-group/incus: new package

990d8d2

It's from Gentoo commit 91137d52c4f6307b512c6f447236bc75e8f8b3ec. Signed-off-by: Mathieu Tortuyaux <[email protected]>

acct-group/incus-admin: new package

2edf456

It's from Gentoo commit 91137d52c4f6307b512c6f447236bc75e8f8b3ec. Signed-off-by: Mathieu Tortuyaux <[email protected]>

app-containers/incus: new package

4dbfe90

It's from Gentoo commit 91137d52c4f6307b512c6f447236bc75e8f8b3ec. Signed-off-by: Mathieu Tortuyaux <[email protected]>

board: add incus

e976524

Signed-off-by: Mathieu Tortuyaux <[email protected]>

sysext: add incus

df4b910

Sort the sysext entries as well. Signed-off-by: Mathieu Tortuyaux <[email protected]>

config/acct-group: provide userdb group record

0355630

this is required when loading the sysext image to dynamically load / unload the groups provided by the image. Signed-off-by: Mathieu Tortuyaux <[email protected]>

build_library: Add mangle script for incus sysext

47f47b4

This requests the `incus.service` for the multi-user.target Signed-off-by: Mathieu Tortuyaux <[email protected]>

profiles: set use flags for lxc

4bc0e8c

Signed-off-by: Mathieu Tortuyaux <[email protected]>

app-containers/incus: fix cross-compilation issue

761719a

While building on `amd64`: ```bash dosbin: _dist/bin/linux_amd64/incusd does not exist ``` Signed-off-by: Mathieu Tortuyaux <[email protected]>

overlay profiles: accept unstable incus & friends for arm64

5c566fb

Signed-off-by: Mathieu Tortuyaux <[email protected]>

.github: add incus and friends to automation

7ac2843

Signed-off-by: Mathieu Tortuyaux <[email protected]>

changelog: add entry

7ccc2f4

Signed-off-by: Mathieu Tortuyaux <[email protected]>

tormath1 force-pushed the tormath1/exp-incus branch from e20e6bd to 7ccc2f4 Compare May 19, 2025 09:27

tormath1 had a problem deploying to development May 19, 2025 09:27 — with GitHub Actions Failure

krnowak approved these changes May 19, 2025

View reviewed changes

tormath1 mentioned this pull request May 19, 2025

incus: initial documentation flatcar/flatcar-website#423

Merged

tormath1 merged commit 886b997 into main May 19, 2025

github-actions Bot mentioned this pull request May 22, 2025

Monthly contributions report 2025-04-22 - 2025-05-21 flatcar/Flatcar#1753

Closed

Navigation Menu

Repository navigation

sysext: add built-in Incus sysext image - #1655

sysext: add built-in Incus sysext image#1655
tormath1 merged 20 commits into
mainfrom
tormath1/exp-incus

tormath1 commented Feb 13, 2024 •

edited by danzatt

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment was marked as outdated.

github-actions Bot commented Mar 13, 2024 •

edited

Loading

Uh oh!

Uh oh!

krnowak May 16, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This branch had an error being deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

tormath1 commented Feb 13, 2024 • edited by danzatt Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment was marked as outdated.

github-actions Bot commented Mar 13, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

krnowak May 16, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This branch had an error being deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

tormath1 commented Feb 13, 2024 •

edited by danzatt

Loading

github-actions Bot commented Mar 13, 2024 •

edited

Loading