Skip to content

incus: remove subuid / subgid creation from sysext - #3028

Merged
tormath1 merged 2 commits into
mainfrom
tormath1/incus
Jun 20, 2025
Merged

tormath1 merged 2 commits into
mainfrom
tormath1/incus

Conversation

@tormath1

@tormath1 tormath1 commented Jun 18, 2025 •

Copy link
Copy Markdown
Contributor

incus: remove subuid / subgid creation from sysext

This create more issues than it solves:

  • override existing subuid / subgid
  • not flexible for the end user
  • it has to be created only once (while tmpfiles always try to create
    those files)

I think Flatcar should not be responsible to create this and it should
be documented (flatcar/flatcar-website#441) on how to do it through Ignition:

version: 1.1.0
variant: flatcar
storage:
  files:
    - path: /etc/subuid
      append:
        - inline: |
            root:1065536:65536
    - path: /etc/subgid
      append:
        - inline: |
            root:1065536:65536

Tested with the produced image:

core@localhost ~ $ cat /etc/subuid
foo:100000:65536
root:1065536:65536

with:

# config.yaml
# butane < config.yaml > config.json
variant: flatcar
version: 1.1.0
passwd:
  users:
    - name: foo
storage:
  files:
    - path: /etc/subuid
      append:
        - inline: |
            root:1065536:65536
    - path: /etc/subgid
      append:
        - inline: |
            root:1065536:65536
    - path: /etc/flatcar/enabled-sysext.conf
      contents:
        inline: |
          incus

I think we should do the same for Podman, but we need to think about a migration path as it will break existing workload.

This create more issues than it solves:
* override existing subuid / subgid
* not flexible for the end user
* it has to be created only once (while tmpfiles always try to create
  those files)

I think Flatcar should not be responsible to create this and it should
be documented on how to do it through Ignition:
```yaml
version: 1.1.0
variant: flatcar
storage:
  files:
    - path: /etc/subuid
      append:
        - inline: |
            root:1065536:65536
    - path: /etc/subgid
      append:
        - inline: |
            root:1065536:65536
```

Signed-off-by: Mathieu Tortuyaux <[email protected]>
Signed-off-by: Mathieu Tortuyaux <[email protected]>
@tormath1 tormath1 moved this to ✅ Testing / in Review in Flatcar tactical, release planning, and roadmap Jun 18, 2025
@tormath1
tormath1 marked this pull request as ready for review June 18, 2025 12:57
@tormath1
tormath1 requested a review from a team June 18, 2025 12:57
@tormath1
tormath1 merged commit 628414b into main Jun 20, 2025
@github-project-automation github-project-automation Bot moved this from ✅ Testing / in Review to Implemented in Flatcar tactical, release planning, and roadmap Jun 20, 2025
@tormath1
tormath1 deleted the tormath1/incus branch June 20, 2025 14:07
@tormath1

Copy link
Copy Markdown
Contributor Author

Cherry-picked to:

  • flatcar-4344

@github-actions

Copy link
Copy Markdown

Build action triggered: https://github.com/flatcar/scripts/actions/runs/15780840248

This branch had an error being deployed

1 failed deployment
development — b1d1157e Deployed Jun 18, 2025 by tormath1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants