Repository navigation
dir: Reload DBus daemon config to ensure services get picked up - #5720
Merged
Merged
Conversation
smcv
requested changes
Mar 15, 2024
smcv
left a comment
smcv
left a comment
Collaborator
There was a problem hiding this comment.
This seems generally fine, just a style issue.
This is best effort. There is a 2s timeout and if something fails everything continues on. This is called from flatpak_dir_run_triggers because it gets called whenever we might have changes to the exported service files. Fixes flatpak#3342 Signed-off-by: Sebastian Wick <[email protected]>
swick
force-pushed
the
wip/maybe-reload-dbus-config
branch
from
March 15, 2024 18:55
e8b10f1 to
79d404f
Compare
smcv
approved these changes
Mar 20, 2024
Collaborator
|
This looks good, but I notice that some of the tests timed out. I've retried in the hope that this was a transient CI issue, rather than this change causing the tests to get stuck for whatever reason. |
Collaborator
|
all my recent PR have been stuck like that. Including changes in doc. |
2 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is best effort. There is a 2s timeout and if something fails everything continues on.
This is called from flatpak_dir_run_triggers because it gets called whenever we might have changes to the exported service files.