Repository navigation
repair: disable auto-pin to preserve pin state across reinstalls - #6571
Merged
Merged
Conversation
bbhtt
reviewed
Apr 10, 2026
bbhtt
reviewed
Apr 10, 2026
bbhtt
reviewed
Apr 10, 2026
Collaborator
|
Seems fine now. |
Contributor
Author
|
Should I squash? |
Collaborator
|
Yes please. It makes sense to always push a squashed, or rather a clean-history version. It's easier to review and github, gitlab, etc all provide a function to diff between pushes. |
Contributor
Author
|
Yeah, I rarely use those, I usually commit on top and just squash at the end, when everything has been checked. |
When repair (re)installs runtimes via a transaction, the transaction auto-pins every runtime it touches. This causes repair --reinstall-all to pin every installed runtime, cluttering the pin list with runtimes that were never explicitly pinned by the user and preventing flatpak remove --unused from cleaning them up. Fix this by disabling auto-pinning on the repair transaction so that the pin state is left exactly as it was before the repair. Fixes flatpak#6565
razzeee
force-pushed
the
issue-6565-repair-pin
branch
from
April 10, 2026 13:45
ec84d64 to
6097f01
Compare
bbhtt
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When repair (re)installs runtimes via a transaction, the transaction auto-pins every runtime it touches. This causes repair --reinstall-all to pin every installed runtime, cluttering the pin list with runtimes that were never explicitly pinned by the user and preventing flatpak remove --unused from cleaning them up.
Fix this by disabling auto-pinning on the repair transaction so that the pin state is left exactly as it was before the repair.
Fixes #6565