Repository navigation
libtest: Allow adding a new ref to an existing temporary ostree repo - #6592
Merged
Merged
Conversation
Collaborator
Author
|
This works in an artificial test environment (qemu VM) similar to the one where Debian runs automated tests in practice. I ran into #6593 while trying to test it manually in a non-minimal environment (a VM with GNOME 49 and development tools) but I don't think that's a regression. |
swick
approved these changes
Apr 10, 2026
bbhtt
reviewed
Apr 10, 2026
smcv
marked this pull request as draft
April 10, 2026 12:50
smcv
marked this pull request as ready for review
April 10, 2026 14:03
When we run `tests/test-run-custom.sh` as a build-time test,
we expect to already have the necessary runtimes, apps, etc. in
`${builddir}/tests/runtime-repo`. However, when running "as-installed"
tests, we're using a fresh temporary ostree repo for each test.
Merely having the repo exist is not enough: for some tests, and in
particular `tests/test-run-custom.sh`, it needs to have more than one
runtime available.
Resolves: flatpak#6591
Signed-off-by: Simon McVittie <[email protected]>
smcv
force-pushed
the
run-custom-insttest
branch
from
April 10, 2026 14:04
17c8ff8 to
e01befb
Compare
Collaborator
Author
|
Fixed logic error, thanks @bbhtt |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we run
tests/test-run-custom.shas a build-time test, we expect to already have the necessary runtimes, apps, etc. in${builddir}/tests/runtime-repo. However, when running "as-installed" tests, we're using a fresh temporary ostree repo for each test. Merely having the repo exist is not enough: for some tests, and in particulartests/test-run-custom.sh, it needs to have more than one runtime available.Resolves: #6591