Skip to content

tests: call g_test_skip() when root-owned directory is absent in test_claim_per_app_temp_directory - #6596

Merged
smcv merged 1 commit into
flatpak:mainfrom
razzeee:test-suite-omission
Apr 10, 2026
Merged

smcv merged 1 commit into
flatpak:mainfrom
razzeee:test-suite-omission

Conversation

@razzeee

@razzeee razzeee commented Apr 10, 2026

Copy link
Copy Markdown
Contributor

Make sure the test suite knows, that this test is skipped

@smcv

smcv commented Apr 10, 2026

Copy link
Copy Markdown
Collaborator

This seems a bit misleading: in each case, the rest of the test has been done, and it's only one small part of it that has been skipped. GLib's test framework doesn't really have a representation for skipping things at a granularity smaller than test case functions.

At the moment it's reported too optimistically (part was run and part was skipped, but we say success anyway), but with the change you're proposing it'll be reported too pessimistically (part was run and part was skipped, but we say skipped anyway).

@razzeee

razzeee commented Apr 10, 2026

Copy link
Copy Markdown
Contributor Author

Agreed, I'm unsure how to get out of this ambiguity. I guess we could spin these into their own tests, but that might be over kill.

I'm fine to close this, if you think it's insignificant enough.

@smcv

smcv commented Apr 10, 2026

Copy link
Copy Markdown
Collaborator

I'm fine to close this, if you think it's insignificant enough.

That would be my inclination. Maybe a g_test_message() instead?

@razzeee
razzeee force-pushed the test-suite-omission branch from c3c8274 to 12f6cd9 Compare April 10, 2026 15:42
@razzeee

razzeee commented Apr 10, 2026

Copy link
Copy Markdown
Contributor Author

Changed to just log.

Still, feel free to close this.

@smcv
smcv added this pull request to the merge queue Apr 10, 2026
@smcv smcv removed the discussion label Apr 10, 2026
Merged via the queue into flatpak:main with commit f5f70a5 Apr 10, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants