Repository navigation
Avoid closing fds 0/1/2, reduce duplication handling fd arguments - #6598
Merged
Merged
Conversation
These fds are stdin, stdout and stderr respectively, and are expected to remain open at all times (if they are not needed then they can point to /dev/null, but they should always be open). If the user gives us `--env-fd=2` or similar, we don't want to close fd 2 before exiting unsuccessfully: that would give us nowhere to display the error message. Signed-off-by: Simon McVittie <[email protected]>
Signed-off-by: Simon McVittie <[email protected]>
smcv
changed the title
Collaborator
Author
|
I'm not sure whether we want both of these in 1.16, or only the first. |
swick
approved these changes
Apr 10, 2026
Collaborator
|
With the amount of code we pushed into 1.16 I don't think it matters to add one more commit, and at least then we have the same code in main as well. |
Collaborator
Author
Yeah, fair enough. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up after fixing #6582.
app, context: Never close fds 0, 1 or 2
These fds are stdin, stdout and stderr respectively, and are expected
to remain open at all times (if they are not needed then they can point
to /dev/null, but they should always be open). If the user gives us
--env-fd=2or similar, we don't want to close fd 2 before exitingunsuccessfully: that would give us nowhere to display the error message.
app, context: Factor out flatpak_accept_fd_argument()