Repository navigation
portal: Actually use the AppInfo hash table - #6613
Merged
Merged
Conversation
Before this change, the hash table was populated with the keyfile as key and value, but the lookup and invalidate was done on the sender as the key. We never found a previous sender, and never invalidated one. Fix this by actually using the sender as the key.
smcv
approved these changes
Apr 13, 2026
Collaborator
|
Let's have this in the next 1.16.x release, too: the cache misses will be an ongoing memory leak in a long-running portal. |
github-merge-queue
Bot
removed this pull request from the merge queue due to no response for status checks
Apr 13, 2026
Collaborator
|
FYI, we seem to be having some trouble with CI sometimes stalling and never producing a result. (A Github issue? An issue in our CI? ...? 🤷 ) |
Collaborator
Author
|
Yeah, it seems to get stuck downloading packages. In xdp we build an image on demand in the CI with the deps, like we do with freedesktop templates. That tends to help with this kind of stuff. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this change, the hash table was populated with the keyfile as key and value, but the lookup and invalidate was done on the sender as the key.
We never found a previous sender, and never invalidated one.
Fix this by actually using the sender as the key.