Repository navigation
Improve Flatpak-Upgrade-From handling - #6626
Merged
swick merged 2 commits intoApr 21, 2026
Merged
Conversation
swick
reviewed
Apr 16, 2026
swick
left a comment
swick
left a comment
Collaborator
There was a problem hiding this comment.
Nice! A few details that should change, but looks good.
razzeee
force-pushed
the
fix/upgrade-from-header-system-helper
branch
3 times, most recently
from
April 16, 2026 13:16
141639d to
a4b204c
Compare
Contributor
Author
|
Not sure why the untouched tests fail now, but seem to work fine in main. |
Collaborator
|
razzeee
force-pushed
the
fix/upgrade-from-header-system-helper
branch
from
April 16, 2026 13:43
a4b204c to
29c5ff3
Compare
Collaborator
|
commit message: the prefix should be a place/thing where changes are. So, in this case |
razzeee
force-pushed
the
fix/upgrade-from-header-system-helper
branch
from
April 16, 2026 14:39
29c5ff3 to
e2db30c
Compare
Contributor
Author
|
should I also change that for the test commit? |
Collaborator
|
No, it only touches things in tests, so that's fine. Essentially whatever the "main" part of the commit is. |
bbhtt
reviewed
Apr 18, 2026
swick
approved these changes
Apr 20, 2026
swick
left a comment
swick
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, but can you please always just push a proper version instead of ones with fixup commits?
razzeee
force-pushed
the
fix/upgrade-from-header-system-helper
branch
from
April 21, 2026 07:23
397affe to
f57d6eb
Compare
Add an integration test that verifies the Flatpak-Upgrade-From HTTP header is correctly sent during update operations but absent during fresh installs. This header is used by Flathub to distinguish updates from new installs in download statistics. To support the test, extend web-server.py to optionally log Flatpak-* request headers to a separate file.
…Upgrade-From header is sent
razzeee
force-pushed
the
fix/upgrade-from-header-system-helper
branch
from
April 21, 2026 07:23
f57d6eb to
56f2d42
Compare
Contributor
Author
|
Reworked the commits, sorry, I'm just to used to keep the history like that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds tests for the basic header handling.
Then tests for the headers when the ref file got removed. (fails at this point)
Then a commit to fix that case.