Repository navigation
Fix some return values and replace deprecated GTimeVal with g_get_real_time() - #6646
Merged
Merged
Conversation
UIDs are unsigned; using signed strtoll and int can mishandle high UIDs such as those used by systemd dynamic users.
g_ascii_strtoll returns gint64; storing the result in a narrower type (int, gint) silently truncates large values.
GTimeVal and g_get_current_time() are deprecated since GLib 2.62 and tv_sec is 32-bit on 32-bit platforms, causing Y2038 overflow. g_get_real_time() returns gint64 and is safe on all platforms.
Contributor
Author
|
Seems like this failed due to launchpad not being reachable |
Collaborator
|
Latest commit is bogus, the LLM is hallucinating fixes |
Collaborator
|
First 3 commits look fine though. |
razzeee
force-pushed
the
fix/g-ascii-strtoll-types
branch
from
May 12, 2026 09:09
c98529d to
c009bf5
Compare
Contributor
Author
|
I mean, it made sense in my head and also aligned to the recent changes in cleanup behavior as far as I understood. Removed the commit for now, but expect the CI to fail again - or it is just flaky. |
Collaborator
|
it is missing the context of the ostree api |
bbhtt
changed the title
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
May 12, 2026
Collaborator
|
Seems like this is triggering some test failures, probably worth investigating. |
Collaborator
|
The CodeQL action failed due to GitHub issues, not test failures. |
Collaborator
|
https://github.com/flatpak/flatpak/actions/runs/25328415204/job/74440616043?pr=6646 At least that run had |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.