Skip to content

run: Add /dev/kfd to dri device permission - #6648

Merged
swick merged 1 commit into
flatpak:mainfrom
razzeee:dev/kfd-dri-permission
May 27, 2026
Merged

swick merged 1 commit into
flatpak:mainfrom
razzeee:dev/kfd-dri-permission

Conversation

@razzeee

@razzeee razzeee commented May 6, 2026

Copy link
Copy Markdown
Contributor

/dev/kfd is used for AMD ROCm/OpenCL compute. Add it to the dri device list so apps can request GPU compute access without needing --device=all.

Fixes: #5383

A bit unsure about the wording in docs

Comment thread doc/flatpak-metadata.xml Outdated
@razzeee
razzeee force-pushed the dev/kfd-dri-permission branch from 3866d6b to af178e8 Compare May 12, 2026 23:47
@swick

swick commented May 13, 2026

Copy link
Copy Markdown
Collaborator

We didn't add anything to the docs for the nvidia compute things either. Maybe we should make this very generic and just say "GPU graphics and compute (including DRI render devices, vendor specific render devices, and vendor specific compute devices)"

@razzeee

razzeee commented May 13, 2026

Copy link
Copy Markdown
Contributor Author

Who's the target audience for this doc? If it's app devs, they likely won't know what /kfd or even /dri is, they are not kernel devs - I think omitting the vendors is a good idea on paper, but might undermine the usefulness of this.

@swick

swick commented May 13, 2026

Copy link
Copy Markdown
Collaborator

I mean, one issue is that new drivers emerge, old ones get unimportant, so this has to change over time anyway. If you really need to know the exhaustive list, you can find it in the code or just inspect the sandbox.

@razzeee
razzeee force-pushed the dev/kfd-dri-permission branch from af178e8 to b17efd9 Compare May 13, 2026 11:22
@razzeee

razzeee commented May 13, 2026

Copy link
Copy Markdown
Contributor Author

Adopted your wording and added the tags into it.

Comment thread doc/flatpak-metadata.xml Outdated
Comment on lines +305 to +306
Support for <filename>/dev/kfd</filename> was
added in 1.17.8.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the intention was to drop this line so that we don't have to keep updating the doc as things are added.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So no documentation, which version added an extension?

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They are all optional anyway, so clients must handle them not being available, so the version does not add any value.

/dev/kfd is used for AMD ROCm/OpenCL compute. Add it to the dri
device list so apps can request GPU compute access without
needing --device=all.

Fixes: flatpak#5383
@razzeee
razzeee force-pushed the dev/kfd-dri-permission branch from b17efd9 to da4e6e2 Compare May 21, 2026 11:33
@swick
swick added this pull request to the merge queue May 27, 2026
Merged via the queue into flatpak:main with commit 8fd0f5d May 27, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature request]: Add /dev/kfd device permission

3 participants