Repository navigation
completion: Add Bash completion for flatpak-coredumpctl - #6678
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
2a9f2ee to
1eed910
Compare
1eed910 to
136d65c
Compare
e2820b1 to
bdefee4
Compare
e117268 to
c8c80d5
Compare
completion: Use readarray for splitting output
c8c80d5 to
d7e4b76
Compare
|
Don't know much about bash completion but can't this be implemented in flatpak-coredumpctl itself? |
|
Some parts of it could be, at the cost of having to run python on every tab press and a bit more complexity. There wouldn't be a lot to gain here, with the main benefit being that it would be possible for a few of the options (like, 3 or 4 of them) for the debug subcommand to be discovered from the argparse parser instead of needing to be explicitly listed. |
|
Just remembered there was one more thing I forgot to do. Right now meson installs the flatpak-coredumpctl completion even if flatpak-coredumpctl itself isn't being installed. |
|
Hm, actually, it looks like it unconditionally installs that anyway? I just assumed not because both Fedora and Ubuntu have it in a separate package from flatpak itself. |
3 participants
Resolves #2001 (Though an issue for fish and zsh completion should probably be made as well).
There are also a few bits of cleanup to the main flatpak bash completion.
This is a draft because it is based on the new interface for flatpak-coredumpctl from #6705, and I will be updating this PR to be in sync with any changes made to that one after it receives feedback. Once that one is merged I will mark this as ready for review.