Skip to content

transaction: Add flatpak_transaction_progress_get_bytes_per_second() - #6679

Merged
swick merged 1 commit into
flatpak:mainfrom
razzeee:transaction-spped
Jun 23, 2026
Merged

swick merged 1 commit into
flatpak:mainfrom
razzeee:transaction-spped

Conversation

@razzeee

@razzeee razzeee commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Right now this mirrors the cli formula for the connection speed.

We could go for a different formula, e.g. speed the last few seconds, but that might be confusing.

@razzeee
razzeee force-pushed the transaction-spped branch from 8fda395 to a37af30 Compare June 8, 2026 08:47
@swick

swick commented Jun 8, 2026

Copy link
Copy Markdown
Collaborator

Naive question: isn't flatpak_transaction_progress_get_bytes_transferred and flatpak_transaction_progress_get_start_time enough to get the same information?

@razzeee

razzeee commented Jun 8, 2026

Copy link
Copy Markdown
Contributor Author

yes, but every downstream would have to do that - not sure if we want that.

And extra data downloads need different handling with start_time_extra_data

Comment thread common/flatpak-progress.c Outdated
Comment thread common/flatpak-progress.c Outdated
@razzeee
razzeee force-pushed the transaction-spped branch from a37af30 to 84ec960 Compare June 9, 2026 11:51
Comment thread common/flatpak-transaction.c Outdated
Comment thread common/flatpak-progress.c Outdated
@razzeee
razzeee force-pushed the transaction-spped branch from 84ec960 to b255ce1 Compare June 9, 2026 14:43
@swick
swick added this pull request to the merge queue Jun 23, 2026
@swick
swick removed this pull request from the merge queue due to a manual request Jun 23, 2026
Comment thread common/flatpak-transaction.c Outdated
@razzeee
razzeee force-pushed the transaction-spped branch from b255ce1 to 2264d7f Compare June 23, 2026 09:41
@swick
swick enabled auto-merge June 23, 2026 09:43
@swick
swick added this pull request to the merge queue Jun 23, 2026
Merged via the queue into flatpak:main with commit 4006907 Jun 23, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants