Repository navigation
Fixed negated permission string for allow and share run options - #6684
Merged
Merged
Conversation
Collaborator
|
Yikes. Could you put the PR description in the commit message please? |
It was solved partially in e0e1b20, but not for completely disallowed code path. Steps to reproduce: 1. Run any flatpak with explicit --unshare option, e.g: [user@user-standardpc ~]$ flatpak run --unshare=network --command=bash io.gitlab.librewolf-community 2. Inside flatpak shell spawn any executable: [io.gitlab.librewolf-community ~]$ flatpak-spawn ls / Result is: error: Unknown option --noshare=network
Contributor
Author
|
Commit message updated. |
Collaborator
|
Thanks |
Collaborator
|
This would benefit from a small unit test to match the expected output. I may add one. |
This was referenced Jun 17, 2026
4 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was solved partially in e0e1b20, but not for completely disallowed code path.
Steps to reproduce:
[user@user-standardpc ~]$ flatpak run --unshare=network --command=bash io.gitlab.librewolf-community[📦 io.gitlab.librewolf-community ~]$ flatpak-spawn ls /error: Unknown option --noshare=network