Repository navigation
Some curl fixes - #6685
Merged
Merged
Some curl fixes#6685
Conversation
TingPing
approved these changes
Jun 12, 2026
Collaborator
|
it would be useful to document the motivation in the commit body and the tests seem to be failing. |
Contributor
Author
|
Yeah, that was a real bug, that was surfaced by that I think. |
Collaborator
|
Two things:
|
Signature downloads can use a different URL from the OCI registry itself, so they must not depend on TLS options left on the reused curl handle. Resolve certificates for the URI and pass them explicitly.
Previously the curl object potentially leaked cert infos from different urls
We did not report the written bytes of the aborted stream before - so curl thought that we wrote all bytes.
Contributor
Author
|
Updated accordingly. |
swick
reviewed
Jun 15, 2026
| NULL, NULL, NULL, | ||
| cancellable, &local_error); | ||
| certificates = flatpak_get_certificates_for_uri (uri_s, &local_error); | ||
| if (local_error) |
Collaborator
There was a problem hiding this comment.
FWIW, I prefer to check the result of the function call (certificates == NULL) instead of the error itself, but this is inconsistent in flatpak, so let's not block on it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.