Repository navigation
run: Error out if file forwarding of empty paths is attempted - #6693
Merged
Merged
Conversation
The file forwarding feature errors out when the path or URI does not lead to an actual file that can be forwarded. The empty path never describes an actual file, so we always have to error out. Without the check, we would get a NULL path from `flatpak_file_get_path_cached` and crash later. Closes: flatpak#6689
bbhtt
approved these changes
Jun 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The file forwarding feature errors out when the path or URI does not lead to an actual file that can be forwarded. The empty path never describes an actual file, so we always have to error out.
Without the check, we would get a NULL path from
flatpak_file_get_path_cachedand crash later.Closes: #6689