Repository navigation
cli: Don't set no_interaction for --assumeyes - #6744
Merged
Merged
Conversation
The --assumeyes (-y) option was setting both the CLI-level disable_interaction flag and the library-level no_interaction flag to TRUE. This caused -y to suppress not just confirmation prompts, but also credential prompts (basic auth, webflow), polkit authorization dialogs, and parental control consent -- even though -y is documented as "automatically answer yes to all questions". Rename disable_interaction to assume_yes to clarify its purpose: it auto-answers yes/no confirmations and picks default choices. Stop calling flatpak_transaction_set_no_interaction() from the CLI transaction constructor, so the library-level no_interaction flag is only set by --noninteractive (which uses FlatpakQuietTransaction). Remove the assume_yes guard from basic_auth_start so credential prompts are always shown when the CLI transaction is in use. Assisted-by: Cursor
Contributor
Author
|
This should also fix #6085, although I haven't tested it specifically with Polkit dialogs, only with basic auth credentials prompts. |
Collaborator
|
Thanks, looks correct. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The --assumeyes (-y) option was setting both the CLI-level disable_interaction flag and the library-level no_interaction flag to TRUE. This caused -y to suppress not just confirmation prompts, but also credential prompts (basic auth, webflow), polkit authorization dialogs, and parental control consent -- even though -y is documented as "automatically answer yes to all questions".
Rename disable_interaction to assume_yes to clarify its purpose: it auto-answers yes/no confirmations and picks default choices. Stop calling flatpak_transaction_set_no_interaction() from the CLI transaction constructor, so the library-level no_interaction flag is only set by --noninteractive (which uses FlatpakQuietTransaction). Remove the assume_yes guard from basic_auth_start so credential prompts are always shown when the CLI transaction is in use.
Assisted-by: Cursor