Skip to content

docs: Added ostree to the Fedora install commands in CONTRIBUTING - #6755

Merged
TingPing merged 1 commit into
flatpak:mainfrom
StudioGenesis:docs-contributing-fedora-ostree
Aug 5, 2026
Merged

TingPing merged 1 commit into
flatpak:mainfrom
StudioGenesis:docs-contributing-fedora-ostree

Conversation

@StudioGenesis

Copy link
Copy Markdown
Contributor

Install documentation for Fedora is outdated, it's relying on sudo dnf builddep flatpak to install ostree, but ostree was trimmed down in the attached commit to only pull ostree-libs.

Without ostree the tests on a fresh Fedora install result in 10 passes, 55 fails and 1 skip. With ostree, all pass.

No issue on the Debian side.

ab28215 Avoid pulling in all of ostree and only depend on ostree-libs subpackage

@swick

swick commented Aug 5, 2026

Copy link
Copy Markdown
Collaborator

Thanks, looks good. The commit message needs to be adjusted (line limit, prefix, take a look at the git history).

`dnf builddep flatpak` only installs `ostree-devel` and `ostree-libs`.
The standalone `/usr/bin/ostree` binary was trimmed out in 2017. Add `ostree` explicitly to `CONTRIBUTING.md`.
@StudioGenesis
StudioGenesis force-pushed the docs-contributing-fedora-ostree branch from 59c1fcd to 57b42f7 Compare August 5, 2026 22:16
@StudioGenesis

Copy link
Copy Markdown
Contributor Author

Sorry, fairly new to the open source side of things.

Hope I've got it correct now!

@swick

swick commented Aug 5, 2026

Copy link
Copy Markdown
Collaborator

Almost. The commit message content also has a line length limit. It usually makes sense to get an editor do this for you automatically.

@TingPing
TingPing merged commit 1e1e6f4 into flatpak:main Aug 5, 2026
11 checks passed
@StudioGenesis

Copy link
Copy Markdown
Contributor Author

Ok, will do in the future, thanks for the feedback!

@TingPing

TingPing commented Aug 5, 2026

Copy link
Copy Markdown
Member

Oops, sorry the comment came in after I looked at it.

@swick

swick commented Aug 5, 2026

Copy link
Copy Markdown
Collaborator

No worries, I should set up something in the CI for this anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants