Repository navigation
tests: Avoid Meson's strict TAP parsing for now - #6768
Merged
Merged
Conversation
Older versions of Meson parsed TAP output very strictly, and would fail the test when a `g_test_message()` mentions non-UTF-8, which results in GLib adding a prefix on stdout that is not valid TAP syntax. Ideally our error messages should all be valid UTF-8 even if the input is not, but that's a larger refactor that shouldn't block security fix releases, so for now just tell Meson to get the tests' pass/fail status from their exit status rather than parsing their stdout. Signed-off-by: Simon McVittie <[email protected]>
Collaborator
Author
This was #6795. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Older versions of Meson parsed TAP output very strictly, and would fail the test when a
g_test_message()mentions non-UTF-8, which results in GLib adding a prefix on stdout that is not valid TAP syntax.Ideally our error messages should all be valid UTF-8 even if the input is not, but that's a larger refactor that shouldn't block security fix releases, so for now just tell Meson to get the tests' pass/fail status from their exit status rather than parsing their stdout.
cc @swick
This fixes the build regression in 1.19.0. I'll try to propose a PR later to fix the error messages properly, but please don't block security releases on that.