Repository navigation
transaction: Release bundle GPG data as GBytes - #6842
Merged
Merged
Conversation
BundleData retains explicit GPG key data with g_bytes_ref(), but its cleanup treats the data as a GObject. This crashes transaction cleanup when a bundle is installed with explicit key bytes. Use g_clear_pointer() with g_bytes_unref() to release the retained data.
Merged
Collaborator
|
Fixed in 1.18.3, will also be fixed in 1.19.1 when released |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BundleData retains explicit GPG key data with g_bytes_ref(), but its cleanup treats the data as a GObject. This crashes transaction cleanup when a bundle is installed with explicit key bytes.
Use g_clear_pointer() with g_bytes_unref() to release the retained data.