Repository navigation
run: Forward documents using the sandbox mount path - #6848
Merged
Merged
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
razzeee
force-pushed
the
fix/blackbox-file-forwarding
branch
from
September 22, 2026 00:55
f726d89 to
003dcd6
Compare
swick
reviewed
Sep 22, 2026
razzeee
force-pushed
the
fix/blackbox-file-forwarding
branch
5 times, most recently
from
September 22, 2026 21:22
d3a44c8 to
5d68306
Compare
swick
reviewed
Sep 23, 2026
swick
left a comment
swick
left a comment
Collaborator
There was a problem hiding this comment.
Looking good, just nitpicking at this point
razzeee
force-pushed
the
fix/blackbox-file-forwarding
branch
from
September 24, 2026 11:36
08388e4 to
767cf64
Compare
The document portal is mounted at /run/flatpak/doc inside the sandbox, but forwarded arguments used its host mount path. With a nonstandard host runtime directory, that path is inaccessible to the application. Keep the host path local to mount setup and return the sandbox destination to argument forwarding. Preserve NULL when the portal is unavailable. Add real-portal regression tests for user and isolated system installs. Check file read/write, escaped URIs, directories and passthrough controls. Skip the directory subtest on portal interfaces older than version 4.
razzeee
force-pushed
the
fix/blackbox-file-forwarding
branch
from
September 24, 2026 11:39
767cf64 to
8eff694
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The document portal is mounted at /run/flatpak/doc inside the sandbox, but forwarded arguments used its host mount path. With a nonstandard host runtime directory, that path is inaccessible to the application.
Keep the host path local to mount setup and return the sandbox destination to argument forwarding. Preserve NULL when the portal is unavailable.
Add real-portal regression tests for user and isolated system installs. Check file read/write, escaped URIs, directories and passthrough controls. Skip the directory subtest on portal interfaces older than version 4.