Skip to content

Add animation diagrams for new Image APIs - #84

Merged
tvolkert merged 3 commits into
flutter:masterfrom
tvolkert:diagrams
May 29, 2019
Merged

tvolkert merged 3 commits into
flutter:masterfrom
tvolkert:diagrams

Conversation

@tvolkert

Copy link
Copy Markdown
Contributor
  • loadingBuilder
  • frameBuilder

flutter/flutter#32374

@tvolkert
tvolkert requested a review from goderbauer May 29, 2019 20:01

@goderbauer goderbauer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread packages/diagrams/lib/src/image.dart Outdated

@override
Widget build(BuildContext context, ImageProvider image) {
return new Container(

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nuke the "new"?

Comment thread packages/diagrams/lib/src/image.dart Outdated
padding: const EdgeInsets.all(10),
color: Colors.white,
child: ConstrainedBox(
constraints: new BoxConstraints.tight(const Size(400, 400)),

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nuke "new"

Comment thread packages/diagrams/lib/src/image.dart Outdated

@override
Widget build(BuildContext context, ImageProvider image) {
return new Container(

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"new"

Comment thread packages/diagrams/lib/src/image.dart Outdated
padding: const EdgeInsets.all(10),
color: Colors.white,
child: ConstrainedBox(
constraints: new BoxConstraints.tight(const Size(400, 400)),

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"new"

@tvolkert
tvolkert merged commit 39c7363 into flutter:master May 29, 2019
@tvolkert
tvolkert deleted the diagrams branch May 29, 2019 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants