Skip to content

Handle override label in retry for packages repository - #3403

Merged
auto-submit[bot] merged 2 commits into
flutter:mainfrom
keyonghan:packages_override_label
Jan 9, 2024
Merged

auto-submit[bot] merged 2 commits into
flutter:mainfrom
keyonghan:packages_override_label

Conversation

@keyonghan

Copy link
Copy Markdown
Contributor


/// Gets label list for an issue.
Future<List<IssueLabel>>? getIssueLabels(RepositorySlug slug, int issueNumber) async {
return github.issues.listLabelsByIssue(slug, issueNumber).toList();

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does github.issues.listLabelsByIssue return a nullable list?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! If there are no labels, it returns an empty list. Updated.

@ricardoamador ricardoamador left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@keyonghan keyonghan added the autosubmit Merge PR when tree becomes green via auto submit App. label Jan 9, 2024
@auto-submit
auto-submit Bot merged commit fcf4cf7 into flutter:main Jan 9, 2024
@keyonghan
keyonghan deleted the packages_override_label branch March 13, 2024 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[packages] Override labels no longer update on re-runs

2 participants