Repository navigation
Gold status updates for branching - #727
Merged
Merged
Conversation
keyonghan
reviewed
Mar 27, 2020
Comment on lines
+88
to
+89
| if (result.branch != 'pull/${pr.number}') { | ||
| isMasterBranch = false; |
Contributor
There was a problem hiding this comment.
How is the branch look like for a non-master branch?
Contributor
Author
There was a problem hiding this comment.
Ah! I thought cirrus specified a difference. I think instead I should be able to do this with the base ref of the pull request.
Piinks
commented
Mar 27, 2020
Piinks
left a comment
Piinks
left a comment
Contributor
Author
There was a problem hiding this comment.
I've reverted some of the changes and made the base ref the flag for release branches. PTAL. :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds a gold status check to PRs on branches other than master.
It will also provide different messaging for these PRs if a change is found to explain why a divergence between the branch and master may have occurred across golden files.