Skip to content

<exception> variable should be available at all levels of the stack #229

Description

@DanTup

Currently when an exception occurs, we inject an <exception> variable into the top stack frame. This means if you navigate up the stack (eg. if the exception occurred inside the assert implementation but you want to view the code that contained the condition) it's not longer visible.

It'd be better if this variable was "global" while you were paused on the exception so you can see it when at any level of the stack.

Activity

  1. devoncarew commented on Feb 6, 2019

    @devoncarew
    Contributor

    Possibly? Or just do some work to make the location of the exception more visible? We could badge the frame with the exception with a small (e) icon for instance.

  2. DanTup commented on Feb 6, 2019

    @DanTup
    ContributorAuthor

    I think having a popup for the exception directly in the code would be neat, but it's a bit weird not letting the user see the exception from the place where they consider if occurred. Consider:

    assert(false);

    This will break the debugger inside the assert implementation (which today has no source, but hopefully will change). The user really doesn't care about the assert implementation since the thing they need to look at is the line that called assert. Navigating to the frame that contains the assert call but not being able to see the exception text feels awkward (maybe assert is a bad example since the text is just "this condition failed", but in more complicated exceptions, being able to see both the exception text and the code that is faulty is very useful).

  3. added this to the Backlog milestone on Jul 23, 2019
  4. added
    P2important to work on, but not at the top of the work list.
    reproduce to verifyIssues that need to be reproduced to verify that they still exist.
    on Oct 17, 2024
  5. removed
    reproduce to verifyIssues that need to be reproduced to verify that they still exist.
    on Nov 19, 2024
  6. elliette commented on Nov 19, 2024

    @elliette
    Member

    This is still reproducible, removing "reproduce to verify" label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    P2important to work on, but not at the top of the work list.devtools-debugger-screenIssues with the Debugger screen

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions