Skip to content

The devtools flame chart includes a large number of unneeded widgets #2332

Description

@jacob314

There are a large number of empty Padding and SizedBox widgets in the flame chart. We should be able to optimize to eliminate all cases where we have 10 unneeded padding + sized boxes on a row without content. Technically we shouldn't need any padding or empty size boxes as the ExtentDelegateListView can define the spacing between widgets.
Screen Shot 2020-09-11 at 12 23 06 PM

Fyi @kenzieschmoll

Activity

  1. added this to the Backlog milestone on Sep 14, 2020
  2. changed the title [-]The timeline flame chart includes a large number of unneeded widgets[/-] [+]The devtools flame chart includes a large number of unneeded widgets[/+] on Mar 24, 2023
  3. kenzieschmoll commented on Mar 24, 2023

    @kenzieschmoll
    Member

    With the perfetto migration, this no longer affects the performance page, but we do still use this flame chart component in the cpu profiler, so I will leave this issue open until we confirm whether it is still a problem there.

  4. added
    P3issues we think are valid but not important
    on Oct 24, 2024
  5. kenzieschmoll commented on Nov 19, 2024

    @kenzieschmoll
    Member

    We do still include widgets in the tree with a zero size. We should optimize to exclude these widgets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    P3issues we think are valid but not importantdevtools-cpu-profiler-screenIssues related to the CPU Profiler screenflame_chart

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions