Skip to content

Support reviewing history for the logging screen #29

Description

@devoncarew

There's currently no visual change in the logging page when we lose the device connection. We should make sure there is (put a subtle transparent overlay on the logging items?), and do something similar on the other pages as well.

Activity

  1. kenzieschmoll commented on Mar 19, 2019

    @kenzieschmoll
    Member

    The page footer says "no device connected". Upon losing connection, a toast-like dialog is also shown.

  2. kenzieschmoll commented on Mar 19, 2019

    @kenzieschmoll
    Member

    Actually perhaps we should show this UI when we lose device connection? This would be more obvious than the message in the footer.
    Screen Shot 2019-03-19 at 3 55 46 PM

  3. changed the title [-]when we lose connection to the device, make a visual change in the logging page[/-] [+]Consider showing connect UI upon losing device connection[/+] on Mar 19, 2019
  4. added this to the Backlog milestone on Jul 23, 2019
  5. devoncarew commented on Mar 18, 2020

    @devoncarew
    ContributorAuthor

    We do this now, however, users loose all info about the app session (we switch to the connect screen and remove all the other screens). We may want to adjust this as being able to go back and look at data for the app is useful (memory usage? logs info? the timeline info for the last few frames?).

  6. changed the title [-]Consider showing connect UI upon losing device connection[/-] [+]Switch to offline state without losing current data upon losing device connection [/+] on May 26, 2020
  7. changed the title [-]Switch to offline state without losing current data upon losing device connection [/-] [+]Support reviewing history for the logging screen[/+] on May 26, 2023
  8. kenzieschmoll commented on May 26, 2023

    @kenzieschmoll
    Member

    This can be supported by a combination of:

    1. implementing support for loading offline data for the logging screen: Enable offline support for all DevTools screens #4470
    2. ensuring the logging screen supports reviewing history on disconnect - see this commit for reference.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions