Skip to content

TreeNode depth is likely sometimes incorrect #3171

Description

@jacob314

TreeNode.depth assumes that TreeNodes are not modified after the first time depth is accessed but it likely code violates this assumption.
We should probably instead switch to a scheme where TreeNode depth values are invalidated when the tree structure bellow them changes although this needs to be done with care to avoid excessive computations of depth.

Activity

  1. added this to the Backlog milestone on Jun 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    P3issues we think are valid but not importantaudit

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions