Experiments are enabled by default

@polina-c

This is happening in the released version of DevTools. Marking as P0 as we need to get this resolved and see if a cherry pick is possible.
@polina-c

@itsjustkevin

FYI @itsjustkevin, we have some major breakages that made it into the DevTools shipped with the SDK.

kReleaseMode is false for some reasons in the build created by dart ./tool/build_e2e.dart

so this line enables flags:

if (!kReleaseMode) setExperimentsEnabled();

This line does not exist in current version, so we are safe with our release process.

@kenzieschmoll

Thanks for calling this out @kenzieschmoll. I’m assuming in this situation, we need a new dart build and not a new flutter build? I’m still not versed around the devtools release process.

We'll need both a Flutter and Dart SDK release since DevTools is shipped as part of the Dart SDK.

@bkonyi

Thanks @bkonyi.

CC: @XilaiZhang and @godofredoc

thanks for the info! is the bad build also included in the dart version that we used for flutter beta hotfix?

Yes this is on every flutter version starting with 3.7.0-1.1.pre

@itsjustkevin

thanks for explaining! @itsjustkevin in terms of flutter beta hotfix, shall we keep moving forward with the remaining steps, or shall we wait to grab a new dart version, engine cp etc.?

@godofredoc

I think the safest bet here is to push a release with the newest dart hash. I may be wrong here, opinions on the matter @godofredoc?

What would be the impact if we push the beta release as expected and release a hotfix early next week?

The risk would be that the DevTools Performance page is broken and our analytics are turned off until the hotfix goes out.

This is resolved. The 2.20.1 cherrypick made it into the stable release.

Navigation Menu

Repository navigation

Experiments are enabled by default #5073

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Experiments are enabled by default #5073

Description

Activity

bkonyi commented on Jan 19, 2023

polina-c commented on Jan 19, 2023

itsjustkevin commented on Jan 19, 2023

bkonyi commented on Jan 19, 2023

itsjustkevin commented on Jan 19, 2023

XilaiZhang commented on Jan 19, 2023

kenzieschmoll commented on Jan 19, 2023

XilaiZhang commented on Jan 19, 2023

itsjustkevin commented on Jan 20, 2023

godofredoc commented on Jan 20, 2023

kenzieschmoll commented on Jan 20, 2023

kenzieschmoll commented on Jan 25, 2023

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions