Skip to content

Support closing browser tabs when the VM service terminates as an option for launchDevTools #612

Closed

Description

@DanTup

When we launch a browser window with launchDevTools we should have an option to have DevTools close it automatically when the VM terminates (I think this should be a param passed to launchDevTools).

@jacob314 believes we may already have code that does this somewhere.

Activity

  1. DanTup commented on Jun 5, 2019

    @DanTup
    ContributorAuthor

    (Or, at least re-use the tabs)

  2. csells commented on Jun 6, 2019

    @csells

    +1 to reuse the DevTools tab if that's possible or to close the tab if it's not.

  3. added this to the 0.1.2 milestone on Jun 17, 2019
  4. jacob314 commented on Jun 17, 2019

    @jacob314
    Contributor

    This is high priority as it blocks us launching devtools more automatically.

  5. modified the milestones: 0.1.2, 0.1.6 on Jul 22, 2019
  6. DanTup commented on Jul 22, 2019

    @DanTup
    ContributorAuthor

    @jacob314 did you have ideas on how best to do this? I don't mind taking a look. Should it happen automatically when the VM goes away, or maybe there should be another VM service (similar to launchDevTools to closeDevTools) that would close that tab/window?

  7. modified the milestones: 0.1.6, 0.1.5 on Jul 22, 2019
  8. modified the milestones: 0.1.5, 0.1.6 on Aug 6, 2019
  9. DanTup commented on Aug 21, 2019

    @DanTup
    ContributorAuthor

    @jacob314 you said you had some ideas on how to do this - I don't mind having a look with some pointers.

  10. modified the milestones: 0.1.6, 0.1.7 on Aug 28, 2019
  11. modified the milestones: 0.1.8, On Deck on Nov 5, 2019
  12. kenzieschmoll commented on Oct 17, 2024

    @kenzieschmoll
    Member

    @DanTup can this issue be closed?

  13. DanTup commented on Oct 18, 2024

    @DanTup
    ContributorAuthor

    Yeah, I'm not sure there's much value in this now. We support disconnect/reconnect fairly well and we're embedded by default now anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions