Skip to content

P1: Display a warning message if an unsupported browser is used. #66

Closed

Description

@jacob314

We depend on IntersectionObserver which is not available in Safari stable.
In general our UI is only tested on Chrome so even for FireFox it is probably safer to remind users that they should probably be opening the page in Chrome.

Activity

  1. added this to the M2 milestone on Mar 19, 2019
  2. DanTup commented on Mar 22, 2019

    @DanTup
    Contributor

    Windows testing didn't go too well - we might want use simpler inline scripts that don't require loading the Dart code. Brave also isn't caught (because it pretends to be Chrome but we know has issues (#367)) - not sure how well we can detect that when it sounds like it's actively trying to avoid being detectable (because it's low use would make it easier to fingerprint - something it's specifically trying to avoid).

    Edge:

    edge

    IE:

    ie

    Brave:

    brave

  3. DanTup commented on Mar 22, 2019

    @DanTup
    Contributor

    Tested again in IE/Edge using the Dart2JS build, but not a huge amount changed:

    ie

    edge

  4. jacob314 commented on Mar 22, 2019

    @jacob314
    ContributorAuthor

    Looks like Dart doesn't support these platforms well enough so we have to unfortunately perform this capability detection in JS.

  5. DanTup commented on Mar 22, 2019

    @DanTup
    Contributor

    My understanding was that Edge was supported, but I don't know if it's possible to still use APIs that aren't available. If we want to handle IE (I'm not sure if we do, I was just testing for completeness) we probably would need JS though.

    Shout if you want me to pick this up next week (sounds like I may have easiest access to Windows).

  6. changed the title [-]Display a warning message if an unsupported browser is used.[/-] [+]P1: Display a warning message if an unsupported browser is used.[/+] on Apr 1, 2019
  7. kenzieschmoll commented on Apr 12, 2019

    @kenzieschmoll
    Member

    Quick update on this - I'm blocked by setting up my Windows machine. I requested an exception so I could download and install external software, and in doing so, I was told the machine needs to be re-imaged with Vanilla Windows so it has no tie to corp. Hopefully this will get squared away within the next couple business days, and then I'll be able to take a look at the Microsoft Edge case next week.

  8. DanTup commented on Apr 13, 2019

    @DanTup
    Contributor

    I do have easy access to Windows, so if you have any issues getting it sorted, let me know and I can take a look.

  9. kenzieschmoll commented on Apr 16, 2019

    @kenzieschmoll
    Member

    Hey Danny. I'm having some trouble setting my windows machine up. I may have to wait for something to be mailed to me, so that will be at least a couple days until I can start the setup. If you have some extra time and want to look at this, feel free to do so. Happy to help in any way I can! Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions