Migrate to pkg:web #6606

Activity

1. kevmoo

   added 2 commits that reference this issue on Oct 27, 2023

   devtools_app: migrate _analytics_web.dart to pkg:web

   ...

   bb127ec

   devtools_app: migrate _analytics_web.dart to pkg:web (#6607)

   ...

   af87d85
2. kenzieschmoll commented on Oct 31, 2023

   

   kenzieschmoll

   on Oct 31, 2023

   Last edited by kenzieschmoll

   Member

   More actions

   migrations for devtools_app that are not straightforward, or just need a little more attention to figure out:

   • _drag_and_drop_web.dart: uses MouseEvent.offset
   • _framework_initialize_web.dart: for (var element in html.document.body!.querySelectorAll('.legacy-dart'))
   • _export_web.dart: uses Url.createObjectUrl
   • allowed_error_html.dart: uses window.console
   • _logger_html.dart: uses window.console
   • _server_web.dart: there is an outstanding todo to use package:http instead of dart:html here for http requests
     • fixed by Migrate DevTools server to use package:http #6712
   • post_message_web.dart: uses html.window.onMessage.map(...) - addressed by Add onMessage getter to WindowEventGetters extension methods dart-lang/web#95
3. kevmoo commented on Oct 31, 2023

   

   kevmoo

   on Oct 31, 2023

   ContributorAuthor

   More actions

   Console:

   https://pub.dev/documentation/web/0.3.0/helpers/console.html
   https://pub.dev/documentation/web/0.3.0/helpers/$ConsoleExtension.html

   👍React with 👍1Reacted by Kenzie Davisson
4. srujzs commented on Nov 7, 2023

   

   srujzs

   on Nov 7, 2023

   Last edited by srujzs

   Contributor

   More actions

   • MouseEvent.offset: The dart:html version returns a Point with offsetX and offsetY. There's some checking to make sure offsetX is supported, but that's stale since modern browsers should support it: https://developer.mozilla.org/en-US/docs/Web/API/MouseEvent/offsetX. If the Point class is heavily used in devtools, then maybe we should add it as a helper class in package:web. If not, using a record with offsetX and offsetY should probably suffice.
   • createObjectURL: The dart:html version checks for a webkitURL. This is no longer needed as it seems all browsers nowadays support URL: https://developer.mozilla.org/en-US/docs/Web/API/URL so it should be safe to use the package:web version => URL.createObjectURL.
   • html.window.onMessage: I think this needs _ElementEventStreamImpl to be added to the helpers in package:web. A workaround is using event listeners, but Streams are nicer. Sorry, was looking at the wrong code. I think this just needs the existing onMessage to be exposed on top of Window. I think you can just do EventStreamProviders.messageEvent.forTarget(window).
5. kenzieschmoll commented on Nov 9, 2023

   

   kenzieschmoll

   on Nov 9, 2023

   Last edited by kenzieschmoll

   Member

   More actions

   @srujzs
   re: MouseEvent, what about the dataTransfer property?
   event.dataTransfer.dropEffect = 'move';

   re: createObjectURL - more issues:
   
   

   re: html.window.onMessage

   • I addressed this in Add onMessage getter to WindowEventGetters extension methods dart-lang/web#95
6. srujzs commented on Nov 10, 2023

   

   srujzs

   on Nov 10, 2023

   Last edited by srujzs

   Contributor

   More actions

   • I think you'll need to downcast MouseEvent to DragEvent to get dataTransfer, which then has a dropEffect property.

   • You want to avoid importing dart:js here. The type you want is JSArray (I know the naming is unfortunate, but alas). To convert from a list to one, you need a List<JSAny>. This can be created by making content itself a JSString: [content.toJS].toJS should get you want you the JSArray you need.
7. kenzieschmoll commented on Nov 10, 2023

   

   kenzieschmoll

   on Nov 10, 2023

   Member

   More actions

   Thanks @srujzs. Getting closer! A few more errors to go:

   • reader is a FileReader object, and droppedFile is a File object:
     
   • element.style.display = 'none'
   • document.body!.append(element);
   • element.click()
     
8. srujzs commented on Nov 10, 2023

   

   srujzs

   on Nov 10, 2023

   Last edited by srujzs

   Contributor

   More actions

   Nice!

   • I think this is similar to the other issues where this stream getter is not available (onLoadEnd). It does seems to exist on Element, so a hacky workaround until we publish a version with it is to just cast to Element and use onLoad (note that we don't check whether that cast is correct since they're both just some random JS objects in the type system's eyes).
   • lastModifiedData is deprecated in the browser. The right equivalent here is using lastModified to get the ms since epoch to construct a DateTime e.g. DateTime.fromMillisecondsSinceEpoch(droppedFile.lastModifiedDate, isUtc: true).
   • You'll need to downcast here to the Element type you want. I believe downcasting element to HTMLAnchorElement should resolve the rest. Using createElement and then downcasting is a downgrade from the nice dart:html constructors, and maybe we should have a createElementAs<HTMLAnchorElement>()-like helper somewhere.
9. kevmoo commented on Nov 13, 2023

   

   kevmoo

   on Nov 13, 2023

   ContributorAuthor

   More actions

   Closing this out as completed via #6626 - still waiting for dependencies to migrate so we can build w/ wasm
10. kevmoo

    closed this as completedon Nov 13, 2023
11. kenzieschmoll commented on Nov 13, 2023

    

    kenzieschmoll

    on Nov 13, 2023

    Member

    More actions

    Everything has been migrated to package:web except for one file: https://github.com/flutter/devtools/blob/master/packages/devtools_app/lib/src/shared/config_specific/post_message/_post_message_web.dart#L5-L9. Removing this is blocked on a new version of package:web getting rolled into flutter.

    However, if we want to start experimenting with dart2wasm now, apply the changes from this patch and it should compile fine: https://github.com/flutter/devtools/compare/master...kenzieschmoll:dart2wasm-experiment?expand=1.

    @kevmoo
12. kevmoo commented on Nov 13, 2023

    

    kevmoo

    on Nov 13, 2023

    ContributorAuthor

    More actions

    Reopening then. To stay on top of #6606 (comment)
13. kevmoo

    reopened this on Nov 13, 2023
14. kevmoo

    self-assigned this

    on Nov 15, 2023
15. 4 remaining items

    Load more
16. kevmoo

    unassigned

    kevmoo

    and

    srujzs

    on Dec 13, 2023
17. kevmoo commented on Dec 13, 2023

    

    kevmoo

    on Dec 13, 2023

    ContributorAuthor

    More actions

    Glad we're getting numbers on this. I think the only concrete thing blocking us is either migrating the inline gtags or moving to unified_analytics.

    Is the latter tracked anywhere?
18. kenzieschmoll commented on Dec 13, 2023

    

    kenzieschmoll

    on Dec 13, 2023

    Member

    More actions

    migrating to unified_analytics is tracked here: #6242. This is something that @eliasyishak may be picking up in the short term.

    👍React with 👍1Reacted by Elias Yishak
19. kevmoo

    added

    blockedIssue or PR is blocked on another issue or PR.Issue or PR is blocked on another issue or PR.

    on Dec 13, 2023
20. kenzieschmoll

    removed

    blockedIssue or PR is blocked on another issue or PR.Issue or PR is blocked on another issue or PR.

    on May 8, 2024
21. kenzieschmoll

    closed this as completedin #7718on May 8, 2024
22. creatorpiyush

    added 2 commits that reference this issue on Jun 10, 2026

    [file_selector_web] migrate to pkg:web (flutter#5413)

    ...

    0d63bae

    [shared_preferences_web] migrate to pkg:web (flutter#5414)

    ...

    bc5fc40
23. bisor0627

    added 2 commits that reference this issue on Jun 19, 2026

    [file_selector_web] migrate to pkg:web (flutter#5413)

    ...

    d595fdc

    [shared_preferences_web] migrate to pkg:web (flutter#5414)

    ...

    066df9b