Skip to content

devtools_tool release-helper does not create PR #6679

Closed

Description

@polina-c

Used guidance: https://github.com/flutter/devtools/blob/master/tool/RELEASE_INSTRUCTIONS.md#create-a-release-pr

Output:

...

 > devtools_tool update-version current-version
2.30.0
 > git commit -a -m Prepare for release (exitCode: 0, stderr: , stdout: 2.30.0
)
fatal: paths 'for ...' with -a does not make sense
ProcessException: Failed with exit code: 128. 
  Command: git commit -a -m Prepare for release (exitCode: 0, stderr: , stdout: 2.30.0
)

Activity

  1. polina-c commented on Nov 8, 2023

    @polina-c
    ContributorAuthor

    This is what was changed: #6678
    Commit: 43d8fe8

  2. added a commit that references this issue on Nov 8, 2023
  3. DanTup commented on Nov 8, 2023

    @DanTup
    Contributor

    I think the issue is that the commit message doesn't have quotes - but adding quotes raises another issue. I have a possible fix here:

    #6684

    But to avoid similar issues I think we should remove all of the splitting of args by spaces.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions